Skip to content

[fix](index) disable OR predicate for bitmap index#30971

Merged
xiaokang merged 1 commit intoapache:branch-2.0from
xiaokang:disalbe_bitmap_index_or_2.0
Feb 7, 2024
Merged

[fix](index) disable OR predicate for bitmap index#30971
xiaokang merged 1 commit intoapache:branch-2.0from
xiaokang:disalbe_bitmap_index_or_2.0

Conversation

@xiaokang
Copy link
Contributor

@xiaokang xiaokang commented Feb 7, 2024

Proposed changes

pick from master #30951

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@xiaokang
Copy link
Contributor Author

xiaokang commented Feb 7, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 50119 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 69e4ecd462118c517d495c2aaef7e11ef4907176, data reload: false

------ Round 1 ----------------------------------
q1	17544	4345	4320	4320
q2	2029	151	144	144
q3	10273	1910	1949	1910
q4	10103	1229	1288	1229
q5	8440	3946	3969	3946
q6	230	123	121	121
q7	2001	1609	1622	1609
q8	9293	2704	2708	2704
q9	10732	11030	10696	10696
q10	8612	3502	3486	3486
q11	406	250	246	246
q12	461	305	302	302
q13	18372	3969	4019	3969
q14	366	322	319	319
q15	510	450	462	450
q16	690	593	593	593
q17	1113	969	965	965
q18	7269	6859	6861	6859
q19	1674	1524	1524	1524
q20	527	315	299	299
q21	4451	4094	4038	4038
q22	508	406	390	390
Total cold run time: 115604 ms
Total hot run time: 50119 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4291	4282	4335	4282
q2	311	222	229	222
q3	4177	4130	4165	4130
q4	2767	2723	2732	2723
q5	7247	7164	7197	7164
q6	234	121	116	116
q7	3246	2831	2857	2831
q8	4352	4468	4474	4468
q9	17102	17112	16999	16999
q10	4275	4252	4224	4224
q11	746	702	673	673
q12	1039	858	869	858
q13	6737	3753	3716	3716
q14	443	429	428	428
q15	499	452	452	452
q16	757	699	691	691
q17	3912	3882	3780	3780
q18	8840	8690	8837	8690
q19	1713	1704	1670	1670
q20	2377	2141	2095	2095
q21	8672	8648	8497	8497
q22	1045	968	957	957
Total cold run time: 84782 ms
Total hot run time: 79666 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.82% (8032/21236)
Line Coverage: 29.49% (65468/222008)
Region Coverage: 28.91% (33626/116294)
Branch Coverage: 24.77% (17252/69646)
Coverage Report: http://coverage.selectdb-in.cc/coverage/69e4ecd462118c517d495c2aaef7e11ef4907176_69e4ecd462118c517d495c2aaef7e11ef4907176/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 241717 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 69e4ecd462118c517d495c2aaef7e11ef4907176, data reload: false

query1	931	397	385	385
query2	6513	2194	2058	2058
query3	6919	207	205	205
query4	20002	18110	17938	17938
query5	19708	6562	6504	6504
query6	291	223	229	223
query7	4154	306	307	306
query8	271	232	208	208
query9	3149	2727	2676	2676
query10	422	283	293	283
query11	11228	10664	10710	10664
query12	122	74	69	69
query13	5597	617	630	617
query14	17723	13293	13198	13198
query15	366	228	235	228
query16	6414	271	260	260
query17	1716	1471	854	854
query18	2325	402	401	401
query19	206	150	158	150
query20	80	75	73	73
query21	183	95	91	91
query22	5311	5018	4911	4911
query23	32514	31956	31872	31872
query24	7028	6509	6522	6509
query25	495	423	437	423
query26	523	162	159	159
query27	1901	295	290	290
query28	6186	2241	2232	2232
query29	2836	2707	2617	2617
query30	237	162	158	158
query31	893	723	730	723
query32	69	60	60	60
query33	381	244	234	234
query34	843	478	480	478
query35	1110	918	913	913
query36	1562	1646	1416	1416
query37	89	58	59	58
query38	3053	2985	2915	2915
query39	1387	1324	1326	1324
query40	194	97	95	95
query41	34	30	32	30
query42	88	80	84	80
query43	703	602	647	602
query44	1126	717	714	714
query45	236	228	234	228
query46	1225	974	958	958
query47	1893	1610	1740	1610
query48	961	691	683	683
query49	621	371	363	363
query50	853	597	575	575
query51	5531	5416	5503	5416
query52	95	72	84	72
query53	447	327	321	321
query54	2650	2472	2425	2425
query55	87	76	91	76
query56	199	210	188	188
query57	1255	1234	1130	1130
query58	212	182	182	182
query59	3606	3249	3200	3200
query60	205	186	203	186
query61	87	80	81	80
query62	861	493	534	493
query63	467	336	340	336
query64	2532	1501	1314	1314
query65	3633	3549	3614	3549
query66	770	374	374	374
query67	18564	16069	16431	16069
query68	9284	664	666	664
query69	572	329	356	329
query70	2087	1723	1555	1555
query71	405	319	295	295
query72	6431	3346	3440	3346
query73	734	330	321	321
query74	6300	5875	5824	5824
query75	5494	3707	3661	3661
query76	5751	1148	1178	1148
query77	963	251	247	247
query78	32025	56207	50690	50690
query79	15534	635	626	626
query80	4742	384	379	379
query81	567	237	227	227
query82	1239	98	95	95
query83	331	134	129	129
query84	260	69	67	67
query85	1891	285	276	276
query86	462	397	381	381
query87	3242	3027	3051	3027
query88	6812	2320	2341	2320
query89	443	268	287	268
query90	2509	190	213	190
query91	165	116	124	116
query92	57	51	51	51
query93	5793	569	629	569
query94	1662	204	207	204
query95	1102	1091	1060	1060
query96	641	331	331	331
query97	6494	6247	6330	6247
query98	203	172	171	171
query99	3701	871	889	871
Total cold run time: 351769 ms
Total hot run time: 241717 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.43 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 69e4ecd462118c517d495c2aaef7e11ef4907176, data reload: false

query1	0.03	0.02	0.02
query2	0.06	0.02	0.02
query3	0.25	0.04	0.05
query4	1.81	0.07	0.07
query5	0.53	0.53	0.51
query6	1.28	0.64	0.62
query7	0.01	0.01	0.01
query8	0.03	0.02	0.02
query9	0.52	0.48	0.49
query10	0.54	0.53	0.54
query11	0.12	0.08	0.09
query12	0.12	0.09	0.10
query13	0.61	0.60	0.60
query14	0.80	0.80	0.79
query15	0.78	0.76	0.76
query16	0.39	0.39	0.36
query17	1.04	1.02	1.02
query18	0.25	0.24	0.28
query19	1.91	1.87	1.82
query20	0.02	0.02	0.02
query21	15.47	0.57	0.55
query22	2.21	2.16	1.50
query23	17.45	1.03	0.96
query24	5.27	2.98	1.59
query25	1.72	0.11	0.10
query26	0.40	0.14	0.14
query27	0.10	0.11	0.11
query28	5.18	0.73	0.70
query29	12.58	2.41	2.39
query30	0.60	0.53	0.50
query31	2.83	0.38	0.39
query32	3.39	0.50	0.49
query33	3.09	3.04	3.07
query34	15.27	4.78	4.80
query35	4.88	4.83	4.86
query36	1.08	1.02	1.02
query37	0.05	0.05	0.04
query38	0.03	0.02	0.02
query39	0.02	0.01	0.01
query40	0.15	0.14	0.14
query41	0.06	0.02	0.02
query42	0.02	0.01	0.01
query43	0.02	0.01	0.02
Total cold run time: 102.97 s
Total hot run time: 31.43 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 69e4ecd462118c517d495c2aaef7e11ef4907176 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s

@xiaokang xiaokang merged commit 1982bf5 into apache:branch-2.0 Feb 7, 2024
xiaokang added a commit to xiaokang/doris that referenced this pull request Feb 20, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants