[chore](refactor) refactor some rf code and delete rpc file#31031

Merged

yiguolei merged 5 commits intoapache:masterfrom

Feb 18, 2024

Contributor

yiguolei commented Feb 16, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

doris-robot commented Feb 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Contributor

github-actions bot commented Feb 16, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment

Contributor

github-actions bot commented Feb 16, 2024

clang-tidy review says "All clean, LGTM! 👍"

Contributor Author

yiguolei commented Feb 16, 2024

run buildall

Contributor

github-actions bot commented Feb 16, 2024

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments

Contributor

github-actions bot commented Feb 16, 2024

clang-tidy review says "All clean, LGTM! 👍"

Contributor

github-actions bot commented Feb 16, 2024

clang-tidy review says "All clean, LGTM! 👍"

doris-robot commented Feb 16, 2024

TeamCity be ut coverage result:
Function Coverage: 35.84% (8556/23876)
Line Coverage: 27.78% (69469/250032)
Region Coverage: 26.92% (36047/133896)
Branch Coverage: 23.70% (18431/77758)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d12350e669c60158f83c7f38f0ba205d2c8d9c53_d12350e669c60158f83c7f38f0ba205d2c8d9c53/report/index.html


          [chore](refactor) refactor some rf code and delete rpc file

08395a4

yiguolei force-pushed the fix2 branch from d12350e to 08395a4 Compare

February 17, 2024 14:01

3f7a67a

Contributor

github-actions bot commented Feb 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment

Contributor

github-actions bot commented Feb 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

e4ac69d

Contributor

github-actions bot commented Feb 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

Doris-Extras added 2 commits

February 17, 2024 23:17

27a398f

bab5835

Contributor Author

yiguolei commented Feb 17, 2024

run buildall

Contributor

github-actions bot commented Feb 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment

Contributor

github-actions bot commented Feb 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

doris-robot commented Feb 17, 2024

TeamCity be ut coverage result:
Function Coverage: 35.83% (8554/23874)
Line Coverage: 27.78% (69450/250014)
Region Coverage: 26.91% (36034/133901)
Branch Coverage: 23.69% (18421/77764)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bab5835375ee644137def0a6be973997545029c9_bab5835375ee644137def0a6be973997545029c9/report/index.html

Contributor Author

yiguolei commented Feb 18, 2024

run performance

HappenLee approved these changes

View reviewed changes

Contributor

HappenLee left a comment

LGTM

github-actions bot added the approved label

Contributor

github-actions bot commented Feb 18, 2024

PR approved by at least one committer and no changes requested.

Contributor

github-actions bot commented Feb 18, 2024

PR approved by anyone and no changes requested.

github-actions bot added the reviewed label

zclllyybb approved these changes

View reviewed changes

yiguolei merged commit ac7f7a7 into apache:master

yiguolei added a commit that referenced this pull request


          [chore](refactor) refactor some rf code and delete rpc file (#31031)

a3c78dd


---------

Co-authored-by: yiguolei <yiguolei@gmail.com>

mymeiyi pushed a commit to mymeiyi/doris that referenced this pull request


          [chore](refactor) refactor some rf code and delete rpc file (apache#3…

796dea4

…1031)



---------

Co-authored-by: yiguolei <yiguolei@gmail.com>

yiguolei added a commit that referenced this pull request


          Revert "[chore](refactor) refactor some rf code and delete rpc file (#…

8c6e456

…31031)"

This reverts commit ac7f7a7.

yiguolei mentioned this pull request

Revert "[chore](refactor) refactor some rf code and delete rpc file" #31088

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved reviewed