Skip to content

Conversation

@adonis0147
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

We should link protobuf with libz.a explicitly, otherwise protoc may not be executable due to the missing libz.1.dylib.

2024-02-20T12:24:31.6008030Z [1/60] Generating orc_proto.pb.h, orc_proto.pb.cc
2024-02-20T12:24:31.6037700Z FAILED: c++/src/orc_proto.pb.h c++/src/orc_proto.pb.cc /Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/src/orc-1.9.0/doris_build/c++/src/orc_proto.pb.h /Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/src/orc-1.9.0/doris_build/c++/src/orc_proto.pb.cc 
2024-02-20T12:24:31.6049230Z cd /Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/src/orc-1.9.0/doris_build/c++/src && /Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/installed/bin/protoc -I /Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/src/orc-1.9.0/proto --cpp_out="/Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/src/orc-1.9.0/doris_build/c++/src" /Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/src/orc-1.9.0/proto/orc_proto.proto
2024-02-20T12:24:31.6058110Z dyld[63187]: Library not loaded: /Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/installed/lib/libz.1.dylib
2024-02-20T12:24:31.6066740Z   Referenced from: <E61D5786-D6C3-3E10-B0FA-3D4C0DEEAC8D> /Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/installed/bin/protoc-3.21.11.0
2024-02-20T12:24:31.6080530Z   Reason: tried: '/Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/installed/lib/libz.1.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/installed/lib/libz.1.dylib' (no such file), '/Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/installed/lib/libz.1.dylib' (no such file), '/Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/installed/lib64/libz.1.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/installed/lib64/libz.1.dylib' (no such file), '/Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/installed/lib64/libz.1.dylib' (no such file)
2024-02-20T12:24:31.6096780Z /bin/sh: line 1: 63187 Abort trap: 6           /Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/installed/bin/protoc -I /Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/src/orc-1.9.0/proto --cpp_out="/Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/src/orc-1.9.0/doris_build/c++/src" /Users/runner/work/doris-thirdparty/doris-thirdparty/thirdparty/src/orc-1.9.0/proto/orc_proto.proto
2024-02-20T12:24:31.6102840Z ninja: build stopped: subcommand failed.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@adonis0147
Copy link
Contributor Author

run buildall

@adonis0147
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.77% (8558/23927)
Line Coverage: 27.72% (69418/250428)
Region Coverage: 26.83% (36018/134225)
Branch Coverage: 23.65% (18425/77914)
Coverage Report: http://coverage.selectdb-in.cc/coverage/95b2a235f59ae53f6c6c7841901276ec9e2caf36_95b2a235f59ae53f6c6c7841901276ec9e2caf36/report/index.html

Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 21, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@zxealous zxealous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonis0147 adonis0147 merged commit 89d3e79 into apache:master Feb 21, 2024
@adonis0147 adonis0147 deleted the workflow branch February 21, 2024 03:00
yiguolei pushed a commit that referenced this pull request Feb 21, 2024
We should link protobuf with libz.a explicitly, otherwise protoc may not be executable due to the missing libz.1.dylib.
adonis0147 added a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.5 reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants