-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[chore](third-party) Link protobuf with zlib statically #31173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
|
run buildall |
|
TeamCity be ut coverage result: |
xinyiZzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zxealous
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should link protobuf with libz.a explicitly, otherwise protoc may not be executable due to the missing libz.1.dylib.
Proposed changes
Issue Number: close #xxxWe should link
protobufwithlibz.aexplicitly, otherwiseprotocmay not be executable due to the missinglibz.1.dylib.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...