[fix](topn) Fix key topn block reverse is missed in some cases #31199#31200
Merged
xiaokang merged 2 commits intoapache:branch-2.0from Feb 21, 2024
Merged
[fix](topn) Fix key topn block reverse is missed in some cases #31199#31200xiaokang merged 2 commits intoapache:branch-2.0from
xiaokang merged 2 commits intoapache:branch-2.0from
Conversation
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| size_t num_columns = block->columns(); | ||
| vectorized::IColumn::Permutation permutation; | ||
| for (size_t i = 0; i < num_rows; ++i) permutation.emplace_back(num_rows - 1 - i); |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| for (size_t i = 0; i < num_rows; ++i) permutation.emplace_back(num_rows - 1 - i); | |
| for (size_t i = 0; i < num_rows; ++i) { permutation.emplace_back(num_rows - 1 - i); | |
| } |
| vectorized::IColumn::Permutation permutation; | ||
| for (size_t i = 0; i < num_rows; ++i) permutation.emplace_back(num_rows - 1 - i); | ||
|
|
||
| for (size_t i = 0; i < num_columns; ++i) |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| for (size_t i = 0; i < num_columns; ++i) | |
| for (size_t i = 0; i < num_columns; ++i) { |
be/src/olap/rowset/segment_v2/segment_iterator.cpp:1994:
- block->get_by_position(i).column->permute(permutation, num_rows);
+ block->get_by_position(i).column->permute(permutation, num_rows);
+ }
TPC-H: Total hot run time: 49855 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 240183 ms |
ClickBench: Total hot run time: 30.81 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
pick from master #31199
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...