Skip to content

[enhance](S3) Init default retry strategy for aws s3 sdk#31329

Merged
dataroaring merged 3 commits intoapache:masterfrom
ByteYue:add_default_retry_for_aws_sdk
Feb 28, 2024
Merged

[enhance](S3) Init default retry strategy for aws s3 sdk#31329
dataroaring merged 3 commits intoapache:masterfrom
ByteYue:add_default_retry_for_aws_sdk

Conversation

@ByteYue
Copy link
Contributor

@ByteYue ByteYue commented Feb 23, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Feb 23, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@ByteYue
Copy link
Contributor Author

ByteYue commented Feb 23, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2024

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 23, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Feb 23, 2024

TeamCity be ut coverage result:
Function Coverage: 35.71% (8548/23935)
Line Coverage: 27.54% (69363/251903)
Region Coverage: 26.69% (35977/134795)
Branch Coverage: 23.49% (18389/78272)
Coverage Report: http://coverage.selectdb-in.cc/coverage/986bc4c59f3221d80cd766ff35342ac749d39b7d_986bc4c59f3221d80cd766ff35342ac749d39b7d/report/index.html

gavinchou
gavinchou reviewed Feb 23, 2024
View reviewed changes
dataroaring
dataroaring previously approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ByteYue
Copy link
Contributor Author

ByteYue commented Feb 26, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Feb 26, 2024

TeamCity be ut coverage result:
Function Coverage: 35.70% (8545/23934)
Line Coverage: 27.51% (69357/252085)
Region Coverage: 26.66% (35957/134887)
Branch Coverage: 23.47% (18378/78318)
Coverage Report: http://coverage.selectdb-in.cc/coverage/816c8c3418feb42002fc9868f518a24bffd35c56_816c8c3418feb42002fc9868f518a24bffd35c56/report/index.html

dataroaring
dataroaring approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 54e6b83 into apache:master Feb 28, 2024
yiguolei pushed a commit that referenced this pull request Feb 28, 2024
@ByteYue @Doris-Extras
[enhance](S3) Init default retry strategy for aws s3 sdk (#31329)
f18c853
seawinde pushed a commit to seawinde/doris that referenced this pull request Feb 28, 2024
@ByteYue @seawinde
[enhance](S3) Init default retry strategy for aws s3 sdk (apache#31329)
1d5bf4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ByteYue @doris-robot @gavinchou @dataroaring