[Opt](exec) enable top opt in string, float, double type#31489
Merged
BiteTheDDDDt merged 1 commit intoapache:masterfrom Feb 28, 2024
Merged
[Opt](exec) enable top opt in string, float, double type#31489BiteTheDDDDt merged 1 commit intoapache:masterfrom
BiteTheDDDDt merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
morrySnow
previously approved these changes
Feb 27, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
BiteTheDDDDt
previously approved these changes
Feb 27, 2024
TPC-H: Total hot run time: 37583 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 168575 ms |
ClickBench: Total hot run time: 31.05 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
HappenLee
dismissed stale reviews from BiteTheDDDDt and morrySnow
via
f98b43c
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38227 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 169090 ms |
ClickBench: Total hot run time: 32.67 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
be/src/olap/accept_null_predicate.h
Outdated
| uint16_t _evaluate_inner(const vectorized::IColumn& column, uint16_t* sel, | ||
| uint16_t size) const override { | ||
| if (column.has_null()) { | ||
| if (size == 0) return 0; |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (size == 0) return 0; | |
| if (size == 0) { return 0; | |
| } |
TPC-H: Total hot run time: 37964 ms |
TPC-DS: Total hot run time: 168978 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 32.35 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38076 ms |
TPC-DS: Total hot run time: 168865 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 32.32 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
BiteTheDDDDt
approved these changes
Feb 28, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
zclllyybb
approved these changes
Feb 28, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Feb 28, 2024
enable top opt in string type
yiguolei
pushed a commit
that referenced
this pull request
Feb 28, 2024
enable top opt in string type
yiguolei
pushed a commit
that referenced
this pull request
Feb 29, 2024
enable top opt in string type
xiaokang
pushed a commit
that referenced
this pull request
Mar 5, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
before：
after:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...