[fix](partial update) compaction may cause update failue#31551
Merged
zhannngchen merged 2 commits intoapache:masterfrom Mar 4, 2024
Merged
[fix](partial update) compaction may cause update failue#31551zhannngchen merged 2 commits intoapache:masterfrom
zhannngchen merged 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Feb 28, 2024
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 37823 ms |
TPC-DS: Total hot run time: 169099 ms |
ClickBench: Total hot run time: 31.29 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Yukang-Lian
approved these changes
Mar 4, 2024
xiaokang
pushed a commit
that referenced
this pull request
Mar 7, 2024
zhannngchen
added a commit
to zhannngchen/incubator-doris
that referenced
this pull request
Mar 18, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 18, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Under normal circumstances,
get_rowset_by_idsdoes not need to consider the stale rowset, in other word, if a rowset id is not found in the normal rowset, we can ignore it. This is because even if we handle stale rowset here, we need to recalculate the new rowset generated by the corresponding compaction in the publish phase.However, for partial update, ignoring the stale rowset may cause some keys to not be found in the flush phase (lookup_row_key returns KEY_NOT_FOUND), and thus be mistaken as new keys in the flush phase, which will cause the load to fail in the following two cases:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...