Skip to content

Conversation

@luwei16
Copy link
Contributor

@luwei16 luwei16 commented Mar 4, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@luwei16
Copy link
Contributor Author

luwei16 commented Mar 4, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.42% (8554/24148)
Line Coverage: 27.19% (69407/255233)
Region Coverage: 26.42% (36015/136333)
Branch Coverage: 23.26% (18396/79096)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ad9801565e30654c94185dc3400d643e55a3eecb_ad9801565e30654c94185dc3400d643e55a3eecb/report/index.html

Copy link
Member

@zy-kkk zy-kkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 4, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 31848 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ad9801565e30654c94185dc3400d643e55a3eecb, data reload: false

------ Round 1 ----------------------------------
q1	17745	4621	4626	4621
q2	2101	218	220	218
q3	10401	1090	1079	1079
q4	4697	1087	1084	1084
q5	7658	2015	1995	1995
q6	165	114	117	114
q7	1130	1081	1044	1044
q8	9546	1093	1081	1081
q9	6167	4798	4819	4798
q10	7871	1896	1973	1896
q11	520	332	332	332
q12	807	414	390	390
q13	18080	2921	2959	2921
q14	297	302	290	290
q15	395	364	347	347
q16	559	504	532	504
q17	795	343	346	343
q18	5861	5147	4656	4656
q19	1194	439	454	439
q20	619	441	439	439
q21	6651	2842	2770	2770
q22	526	487	490	487
Total cold run time: 103785 ms
Total hot run time: 31848 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4627	4683	4647	4647
q2	298	215	224	215
q3	2105	1767	1681	1681
q4	1528	1251	1235	1235
q5	3117	2888	2922	2888
q6	179	109	107	107
q7	1841	1829	1773	1773
q8	1903	1684	1685	1684
q9	5298	5144	5174	5144
q10	2627	2239	2301	2239
q11	499	422	421	421
q12	744	647	616	616
q13	2932	2752	2626	2626
q14	272	268	287	268
q15	348	361	325	325
q16	489	487	470	470
q17	1149	805	779	779
q18	5934	5421	4987	4987
q19	1136	707	649	649
q20	1600	1428	1456	1428
q21	4805	4433	4346	4346
q22	665	615	632	615
Total cold run time: 44096 ms
Total hot run time: 39143 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184972 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ad9801565e30654c94185dc3400d643e55a3eecb, data reload: false

query1	989	399	375	375
query2	7821	2457	2368	2368
query3	6734	291	303	291
query4	23034	22336	22514	22336
query5	4338	712	705	705
query6	390	291	288	288
query7	4692	486	468	468
query8	329	276	269	269
query9	8679	3437	3407	3407
query10	572	367	370	367
query11	18031	16380	16867	16380
query12	180	140	138	138
query13	1778	666	662	662
query14	9697	7770	7653	7653
query15	238	240	225	225
query16	7306	401	402	401
query17	975	673	677	673
query18	2002	411	417	411
query19	279	245	245	245
query20	147	141	135	135
query21	231	174	167	167
query22	5201	4965	4883	4883
query23	24056	23336	23484	23336
query24	7437	2128	2066	2066
query25	693	585	577	577
query26	813	247	256	247
query27	2592	505	503	503
query28	3412	2872	2849	2849
query29	1021	776	759	759
query30	324	191	193	191
query31	1529	796	768	768
query32	131	98	91	91
query33	624	379	391	379
query34	1101	658	697	658
query35	962	868	899	868
query36	1281	1128	1188	1128
query37	130	108	108	108
query38	3114	2983	2997	2983
query39	1164	1081	1058	1058
query40	260	164	169	164
query41	90	85	83	83
query42	156	159	172	159
query43	581	593	594	593
query44	1280	1064	1057	1057
query45	221	222	209	209
query46	898	799	795	795
query47	1662	1599	1616	1599
query48	594	524	526	524
query49	716	473	457	457
query50	681	558	559	558
query51	11136	11384	11340	11340
query52	146	168	149	149
query53	344	329	335	329
query54	377	355	363	355
query55	185	134	134	134
query56	347	420	351	351
query57	1050	1017	1034	1017
query58	367	351	330	330
query59	3473	3347	3359	3347
query60	407	374	392	374
query61	166	165	180	165
query62	548	400	411	400
query63	334	323	331	323
query64	4199	1825	1802	1802
query65	2378	2341	2381	2341
query66	1081	393	391	391
query67	14927	14760	14806	14760
query68	4303	724	736	724
query69	672	578	580	578
query70	1570	1616	1603	1603
query71	487	429	415	415
query72	2953	2318	2267	2267
query73	675	492	525	492
query74	7264	6926	7132	6926
query75	3098	2703	2684	2684
query76	2476	618	657	618
query77	586	416	410	410
query78	6581	6642	6250	6250
query79	1135	805	778	778
query80	651	713	597	597
query81	485	262	267	262
query82	181	135	140	135
query83	254	243	238	238
query84	309	132	130	130
query85	941	552	504	504
query86	422	421	467	421
query87	3385	3068	3096	3068
query88	3834	3572	3550	3550
query89	459	425	440	425
query90	1629	231	238	231
query91	204	199	199	199
query92	109	86	83	83
query93	1054	728	722	722
query94	716	280	288	280
query95	592	545	532	532
query96	637	405	396	396
query97	3004	2895	3001	2895
query98	325	324	333	324
query99	1188	753	713	713
Total cold run time: 254810 ms
Total hot run time: 184972 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.14 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ad9801565e30654c94185dc3400d643e55a3eecb, data reload: false

query1	0.05	0.03	0.04
query2	0.10	0.04	0.04
query3	0.27	0.07	0.06
query4	1.60	0.09	0.09
query5	0.51	0.55	0.51
query6	1.52	0.99	1.02
query7	0.04	0.03	0.03
query8	0.07	0.04	0.04
query9	0.71	0.68	0.66
query10	0.68	0.70	0.70
query11	0.22	0.15	0.16
query12	0.20	0.15	0.16
query13	0.52	0.48	0.50
query14	0.72	0.71	0.71
query15	0.94	0.96	0.89
query16	0.41	0.40	0.40
query17	1.17	1.21	1.15
query18	0.31	0.30	0.31
query19	2.19	2.07	2.08
query20	0.02	0.02	0.02
query21	15.36	1.03	0.99
query22	0.59	0.60	0.58
query23	13.70	0.63	0.68
query24	0.75	0.19	0.18
query25	0.04	0.08	0.04
query26	0.22	0.22	0.21
query27	0.06	0.04	0.05
query28	1.59	0.75	0.73
query29	12.73	5.16	4.75
query30	0.89	0.80	0.74
query31	0.87	0.43	0.43
query32	3.24	0.40	0.41
query33	2.44	2.43	2.21
query34	2.21	2.25	2.19
query35	2.18	2.22	2.17
query36	0.99	1.02	1.01
query37	0.08	0.07	0.06
query38	0.06	0.05	0.04
query39	0.03	0.02	0.03
query40	0.23	0.16	0.18
query41	0.08	0.03	0.03
query42	0.05	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 70.68 s
Total hot run time: 27.14 s

@dataroaring dataroaring merged commit 966d500 into apache:master Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants