Skip to content

[bugfix](coordinator) should use fragment id not profile fragment id to cancel fragment#31852

Merged
yiguolei merged 3 commits intoapache:masterfrom
yiguolei:fix_coord
Mar 6, 2024
Merged

[bugfix](coordinator) should use fragment id not profile fragment id to cancel fragment#31852
yiguolei merged 3 commits intoapache:masterfrom
yiguolei:fix_coord

Conversation

@yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Mar 6, 2024

Proposed changes

  1. profile fragment id only used in profile.
  2. not need add update status(xxx,backendid) api, it only reduced one be rpc. but the code is very complex.
  3. Not need instance id parameter in update_status api, since it is only used to print log and the log already print before call this API.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@yiguolei
Copy link
Contributor Author

yiguolei commented Mar 6, 2024

run buildall

Gabriel39
Gabriel39 previously approved these changes Mar 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 6, 2024
@yiguolei
Copy link
Contributor Author

yiguolei commented Mar 6, 2024

run buildall

@yiguolei
Copy link
Contributor Author

yiguolei commented Mar 6, 2024

run buildall

Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit c5fcdab into apache:master Mar 6, 2024
yiguolei added a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants