Skip to content

[Bug](fix) fix or and "<=>" cause coredump in query#31885

Merged
yiguolei merged 1 commit intoapache:branch-2.0from
HappenLee:branch-2.0
Mar 7, 2024
Merged

[Bug](fix) fix or and "<=>" cause coredump in query#31885
yiguolei merged 1 commit intoapache:branch-2.0from
HappenLee:branch-2.0

Conversation

@HappenLee
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor

yiguolei commented Mar 7, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 50215 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5a9db87b36f4f4559d9a5177ab9849bd95f52694, data reload: false

------ Round 1 ----------------------------------
q1	18102	4382	4343	4343
q2	2027	152	150	150
q3	10432	1904	1933	1904
q4	10274	1237	1336	1237
q5	8550	3945	4017	3945
q6	233	122	121	121
q7	2022	1601	1583	1583
q8	9342	2718	2715	2715
q9	11231	10675	10764	10675
q10	8643	3517	3518	3517
q11	422	234	238	234
q12	470	299	306	299
q13	18333	4021	4009	4009
q14	355	323	323	323
q15	522	449	461	449
q16	692	583	591	583
q17	1132	982	970	970
q18	7207	6848	6871	6848
q19	1702	1602	1516	1516
q20	529	308	315	308
q21	4474	4115	4093	4093
q22	505	395	393	393
Total cold run time: 117199 ms
Total hot run time: 50215 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4341	4337	4285	4285
q2	324	234	233	233
q3	4164	4162	4137	4137
q4	2745	2773	2750	2750
q5	7289	7181	7204	7181
q6	236	117	119	117
q7	3238	2867	2840	2840
q8	4396	4455	4451	4451
q9	17651	17396	17224	17224
q10	4347	4235	4246	4235
q11	776	709	726	709
q12	1026	849	848	848
q13	7272	3762	3775	3762
q14	470	424	424	424
q15	507	456	457	456
q16	761	712	697	697
q17	3853	3822	3782	3782
q18	8852	8611	8603	8603
q19	1707	1712	1642	1642
q20	2386	2131	2096	2096
q21	8680	8505	8609	8505
q22	1047	971	964	964
Total cold run time: 86068 ms
Total hot run time: 79941 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.81% (8037/21256)
Line Coverage: 29.50% (65564/222287)
Region Coverage: 28.95% (33728/116487)
Branch Coverage: 24.81% (17309/69780)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5a9db87b36f4f4559d9a5177ab9849bd95f52694_5a9db87b36f4f4559d9a5177ab9849bd95f52694/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 202041 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5a9db87b36f4f4559d9a5177ab9849bd95f52694, data reload: false

query1	906	394	377	377
query2	6508	2230	2141	2141
query3	6922	202	206	202
query4	21120	18044	18052	18044
query5	19708	6527	6556	6527
query6	304	220	230	220
query7	4160	308	316	308
query8	247	250	218	218
query9	3158	2703	2614	2614
query10	431	283	313	283
query11	11391	10763	10677	10677
query12	118	74	76	74
query13	5576	616	624	616
query14	17818	13941	13017	13017
query15	365	248	231	231
query16	6461	268	265	265
query17	1568	1455	878	878
query18	2277	401	404	401
query19	211	141	147	141
query20	81	74	76	74
query21	182	99	106	99
query22	5207	5078	5079	5078
query23	32438	32157	31945	31945
query24	6957	6539	6437	6437
query25	532	418	408	408
query26	528	164	172	164
query27	1873	298	302	298
query28	6102	2210	2197	2197
query29	2855	2899	2754	2754
query30	243	163	160	160
query31	886	713	756	713
query32	65	63	52	52
query33	402	246	261	246
query34	845	465	491	465
query35	1148	941	943	941
query36	1578	1667	1549	1549
query37	93	61	60	60
query38	3146	2891	2906	2891
query39	1376	1312	1319	1312
query40	203	102	96	96
query41	37	32	32	32
query42	88	83	88	83
query43	649	578	613	578
query44	1130	720	706	706
query45	241	230	230	230
query46	1257	992	985	985
query47	1852	1791	1795	1791
query48	1014	690	671	671
query49	620	369	362	362
query50	858	615	586	586
query51	4751	4696	4615	4615
query52	93	73	83	73
query53	441	321	309	309
query54	2670	2490	2456	2456
query55	86	76	83	76
query56	209	195	187	187
query57	1172	1112	1070	1070
query58	216	200	187	187
query59	3407	3066	3223	3066
query60	223	198	192	192
query61	82	80	80	80
query62	842	495	526	495
query63	473	337	348	337
query64	2279	1479	1434	1434
query65	3648	3572	3534	3534
query66	791	372	354	354
query67	17003	15639	15060	15060
query68	9515	649	660	649
query69	566	343	341	341
query70	1724	1736	1680	1680
query71	411	294	298	294
query72	6525	3459	3435	3435
query73	738	327	323	323
query74	6235	5910	5772	5772
query75	5382	3723	3609	3609
query76	5885	1133	1197	1133
query77	997	248	251	248
query78	12792	13540	12062	12062
query79	10430	644	654	644
query80	701	387	383	383
query81	487	227	228	227
query82	255	93	91	91
query83	173	134	130	130
query84	245	67	70	67
query85	767	285	283	283
query86	382	390	372	372
query87	3281	2999	2994	2994
query88	4680	2346	2349	2346
query89	349	316	290	290
query90	2059	216	203	203
query91	147	116	114	114
query92	58	53	51	51
query93	1337	552	542	542
query94	753	194	205	194
query95	1135	1087	1059	1059
query96	632	330	332	330
query97	6573	6378	6497	6378
query98	185	180	176	176
query99	2839	944	899	899
Total cold run time: 310359 ms
Total hot run time: 202041 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.86 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5a9db87b36f4f4559d9a5177ab9849bd95f52694, data reload: false

query1	0.03	0.02	0.02
query2	0.06	0.02	0.02
query3	0.25	0.05	0.04
query4	1.83	0.07	0.06
query5	0.52	0.52	0.52
query6	1.23	0.62	0.61
query7	0.01	0.01	0.01
query8	0.03	0.03	0.03
query9	0.53	0.48	0.46
query10	0.54	0.53	0.54
query11	0.11	0.08	0.09
query12	0.11	0.09	0.09
query13	0.61	0.62	0.60
query14	0.78	0.78	0.81
query15	0.78	0.76	0.77
query16	0.37	0.36	0.38
query17	1.01	1.03	1.01
query18	0.22	0.26	0.24
query19	1.93	1.85	1.81
query20	0.01	0.01	0.01
query21	15.48	0.56	0.55
query22	2.02	2.24	1.86
query23	17.16	0.88	0.96
query24	4.98	3.59	1.00
query25	0.40	0.13	0.04
query26	0.81	0.15	0.15
query27	0.05	0.04	0.03
query28	6.00	0.74	0.72
query29	12.69	2.31	2.28
query30	0.56	0.53	0.51
query31	2.81	0.40	0.37
query32	3.38	0.49	0.49
query33	3.06	3.07	3.06
query34	15.29	4.83	4.78
query35	4.86	4.87	4.84
query36	1.07	1.02	1.01
query37	0.05	0.04	0.04
query38	0.03	0.02	0.02
query39	0.02	0.01	0.01
query40	0.16	0.14	0.14
query41	0.08	0.02	0.01
query42	0.02	0.01	0.01
query43	0.03	0.02	0.02
Total cold run time: 101.97 s
Total hot run time: 30.86 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 5a9db87b36f4f4559d9a5177ab9849bd95f52694 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.0 seconds inserted 10000000 Rows, about 476K ops/s

@yiguolei yiguolei merged commit a7f0849 into apache:branch-2.0 Mar 7, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants