[fix](multi-catalog) add max compute custom odps and tunnel url#31925
Merged
xiaokang merged 2 commits intoapache:branch-2.0from Mar 7, 2024
wsjz:branch-2.0
Merged
[fix](multi-catalog) add max compute custom odps and tunnel url#31925xiaokang merged 2 commits intoapache:branch-2.0from wsjz:branch-2.0
xiaokang merged 2 commits intoapache:branch-2.0from
wsjz:branch-2.0
Conversation
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
github-actions
bot
added
the
kind/docs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const std::string region() const { return _region; } | ||
| const std::string project() const { return _project; } | ||
| const std::string table() const { return _table; } | ||
| const std::string odps_url() const { return _odps_url; } |
Contributor
There was a problem hiding this comment.
warning: function 'odps_url' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| const std::string odps_url() const { return _odps_url; } | |
| [[nodiscard]] const std::string odps_url() const { return _odps_url; } |
| const std::string project() const { return _project; } | ||
| const std::string table() const { return _table; } | ||
| const std::string odps_url() const { return _odps_url; } | ||
| const std::string tunnel_url() const { return _tunnel_url; } |
Contributor
There was a problem hiding this comment.
warning: function 'tunnel_url' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| const std::string tunnel_url() const { return _tunnel_url; } | |
| [[nodiscard]] const std::string tunnel_url() const { return _tunnel_url; } |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
Contributor
|
@wsjz There is compile error |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 49857 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 201899 ms |
ClickBench: Total hot run time: 30.94 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
from #31390
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...