Skip to content

[fix](merge-cloud) use correct fs to create transient rowset writer#31943

Merged
dataroaring merged 3 commits intoapache:masterfrom
zhannngchen:debug-cloud-partial-update-case-fail
Mar 7, 2024
Merged

[fix](merge-cloud) use correct fs to create transient rowset writer#31943
dataroaring merged 3 commits intoapache:masterfrom
zhannngchen:debug-cloud-partial-update-case-fail

Conversation

@zhannngchen
Copy link
Contributor

@zhannngchen zhannngchen commented Mar 7, 2024

Proposed changes

Issue Number: close #xxx

incorrect fs may cause the segment files written by transient rowset writer not uploaded to s3

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@zhannngchen
Copy link
Contributor Author

zhannngchen commented Mar 7, 2024

run buildall

2 similar comments
@zhannngchen
Copy link
Contributor Author

zhannngchen commented Mar 7, 2024

run buildall

@zhannngchen
Copy link
Contributor Author

zhannngchen commented Mar 7, 2024

run buildall

@dataroaring
Copy link
Contributor

dataroaring commented Mar 7, 2024

run buildall

@zhannngchen zhannngchen force-pushed the debug-cloud-partial-update-case-fail branch from ddb10a7 to 5d6029f Compare March 7, 2024 09:36
@zhannngchen
Copy link
Contributor Author

zhannngchen commented Mar 7, 2024

run buildall

liaoxin01
liaoxin01 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

TeamCity be ut coverage result:
Function Coverage: 35.39% (8559/24184)
Line Coverage: 27.14% (69494/256026)
Region Coverage: 26.36% (36050/136735)
Branch Coverage: 23.20% (18421/79406)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5d6029f9b0408efaa229a74de82085c2526100d9_5d6029f9b0408efaa229a74de82085c2526100d9/report/index.html

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

TeamCity be ut coverage result:
Function Coverage: 35.40% (8561/24184)
Line Coverage: 27.15% (69512/256026)
Region Coverage: 26.37% (36060/136735)
Branch Coverage: 23.21% (18430/79406)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5d6029f9b0408efaa229a74de82085c2526100d9_5d6029f9b0408efaa229a74de82085c2526100d9/report/index.html

dataroaring
dataroaring approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit c4a20a4 into apache:master Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhannngchen @doris-robot @dataroaring @liaoxin01