Skip to content

[fix](merge-cloud) Fix gcc compile failed #31961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 7, 2024
Merged

[fix](merge-cloud) Fix gcc compile failed #31961

dataroaring merged 1 commit into from
Mar 7, 2024

Conversation

@liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Mar 7, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@liaoxin01
Copy link
Contributor Author

liaoxin01 commented Mar 7, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

TPC-H: Total hot run time: 38008 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 66d5d449a66f4520c565d976e7e3fa0d45c72c94, data reload: false

------ Round 1 ----------------------------------
q1	17731	4097	4069	4069
q2	2026	164	157	157
q3	10520	949	927	927
q4	4663	947	948	947
q5	7599	2917	3034	2917
q6	176	128	120	120
q7	1298	833	814	814
q8	9500	1998	2292	1998
q9	7214	6507	6441	6441
q10	8226	2586	2614	2586
q11	421	236	209	209
q12	739	322	317	317
q13	17977	2934	2980	2934
q14	272	255	254	254
q15	488	452	453	452
q16	514	394	402	394
q17	947	873	858	858
q18	6885	6021	5873	5873
q19	1559	1531	1521	1521
q20	555	284	280	280
q21	7510	3655	3695	3655
q22	782	291	285	285
Total cold run time: 107602 ms
Total hot run time: 38008 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4032	4006	4000	4000
q2	340	226	225	225
q3	2928	2943	2901	2901
q4	1836	1813	1809	1809
q5	5255	5251	5233	5233
q6	212	115	118	115
q7	2263	1829	1836	1829
q8	3235	3273	3299	3273
q9	8576	8529	8552	8529
q10	6149	3723	3701	3701
q11	532	441	446	441
q12	717	553	551	551
q13	10854	2773	2751	2751
q14	276	255	271	255
q15	471	438	439	438
q16	453	410	399	399
q17	1710	1660	1656	1656
q18	7923	7530	7346	7346
q19	3795	1512	1603	1512
q20	1981	1724	1740	1724
q21	4894	4755	4814	4755
q22	548	462	467	462
Total cold run time: 68980 ms
Total hot run time: 53905 ms

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

TeamCity be ut coverage result:
Function Coverage: 35.36% (8553/24186)
Line Coverage: 27.14% (69489/256032)
Region Coverage: 26.36% (36064/136813)
Branch Coverage: 23.21% (18433/79434)
Coverage Report: http://coverage.selectdb-in.cc/coverage/66d5d449a66f4520c565d976e7e3fa0d45c72c94_66d5d449a66f4520c565d976e7e3fa0d45c72c94/report/index.html

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

TPC-DS: Total hot run time: 186540 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 66d5d449a66f4520c565d976e7e3fa0d45c72c94, data reload: false

query1	916	355	333	333
query2	7354	2169	2015	2015
query3	6711	218	207	207
query4	24477	21048	20931	20931
query5	4282	458	466	458
query6	277	185	177	177
query7	4621	306	286	286
query8	246	180	179	179
query9	8397	2250	2233	2233
query10	470	235	245	235
query11	14944	14252	14549	14252
query12	140	89	88	88
query13	1635	423	432	423
query14	10797	9879	10386	9879
query15	232	190	191	190
query16	7941	279	271	271
query17	1716	593	584	584
query18	2029	299	295	295
query19	198	163	170	163
query20	102	91	89	89
query21	202	129	131	129
query22	4758	4660	4523	4523
query23	31366	30919	30358	30358
query24	10323	3093	3069	3069
query25	686	399	398	398
query26	1085	171	168	168
query27	2323	371	357	357
query28	6126	1822	1816	1816
query29	1017	616	602	602
query30	302	152	153	152
query31	943	740	753	740
query32	109	68	58	58
query33	769	294	263	263
query34	978	467	474	467
query35	848	667	616	616
query36	948	810	832	810
query37	109	77	85	77
query38	3240	3097	3188	3097
query39	1426	1379	1383	1379
query40	212	123	121	121
query41	60	53	54	53
query42	103	101	102	101
query43	425	427	405	405
query44	1054	730	713	713
query45	287	269	265	265
query46	1062	796	769	769
query47	1652	1580	1576	1576
query48	429	354	353	353
query49	1135	352	349	349
query50	786	386	381	381
query51	6810	6634	6663	6634
query52	106	95	93	93
query53	349	284	283	283
query54	308	254	261	254
query55	91	85	81	81
query56	243	230	226	226
query57	1113	1008	1018	1008
query58	251	218	241	218
query59	2499	2277	2393	2277
query60	281	251	280	251
query61	123	115	117	115
query62	652	423	417	417
query63	305	277	276	276
query64	4801	3298	3145	3145
query65	3066	3001	3014	3001
query66	832	321	331	321
query67	15336	14661	14413	14413
query68	13863	550	563	550
query69	725	380	380	380
query70	1858	1101	1101	1101
query71	580	271	271	271
query72	10094	2600	2490	2490
query73	2843	329	340	329
query74	7119	6969	6931	6931
query75	11683	8045	8078	8045
query76	7274	1115	1197	1115
query77	678	276	254	254
query78	10257	9594	9749	9594
query79	9034	523	523	523
query80	2143	443	383	383
query81	500	208	217	208
query82	347	199	200	199
query83	249	150	150	150
query84	284	77	78	77
query85	1249	335	331	331
query86	361	282	305	282
query87	3416	3285	3261	3261
query88	3176	2291	2288	2288
query89	522	363	361	361
query90	2536	176	175	175
query91	164	130	130	130
query92	59	49	52	49
query93	4100	526	509	509
query94	1658	186	183	183
query95	463	342	340	340
query96	595	268	259	259
query97	4475	4332	4326	4326
query98	230	227	222	222
query99	1094	764	758	758
Total cold run time: 313043 ms
Total hot run time: 186540 ms

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

ClickBench: Total hot run time: 29.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 66d5d449a66f4520c565d976e7e3fa0d45c72c94, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.06
query4	1.67	0.10	0.10
query5	0.50	0.50	0.49
query6	1.30	0.66	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.02
query9	0.55	0.55	0.53
query10	0.56	0.57	0.58
query11	0.13	0.10	0.10
query12	0.13	0.11	0.10
query13	0.57	0.57	0.57
query14	0.75	0.74	0.75
query15	0.81	0.80	0.80
query16	0.38	0.36	0.38
query17	0.97	1.02	1.00
query18	0.26	0.28	0.27
query19	1.83	1.72	1.74
query20	0.02	0.02	0.01
query21	15.41	0.63	0.67
query22	3.06	4.18	1.79
query23	17.59	1.10	0.89
query24	2.13	0.57	0.18
query25	0.31	0.04	0.03
query26	0.18	0.13	0.13
query27	0.03	0.03	0.04
query28	12.37	0.84	0.83
query29	12.57	3.16	3.40
query30	0.59	0.55	0.61
query31	2.80	0.34	0.33
query32	3.40	0.42	0.44
query33	2.96	2.86	2.89
query34	15.53	4.34	4.33
query35	4.35	4.36	4.30
query36	1.08	1.02	1.02
query37	0.07	0.05	0.06
query38	0.05	0.04	0.04
query39	0.02	0.01	0.02
query40	0.20	0.14	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.65 s
Total hot run time: 29.95 s

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 66d5d449a66f4520c565d976e7e3fa0d45c72c94 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       17.7 seconds inserted 10000000 Rows, about 564K ops/s

dataroaring
dataroaring approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 8f67af6 into apache:master Mar 7, 2024
@liaoxin01 liaoxin01 deleted the fix_compile branch March 8, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liaoxin01 @doris-robot @gavinchou @dataroaring