[fix](cloud) fix auto analyze triggering failure#32139
Merged
dataroaring merged 3 commits intoapache:masterfrom Mar 12, 2024
Merged
[fix](cloud) fix auto analyze triggering failure#32139dataroaring merged 3 commits intoapache:masterfrom
dataroaring merged 3 commits intoapache:masterfrom
Conversation
StatisticsCollector only collect when replicas are normal. In cloud mode, this check needs setCloudCluster before execution. Otherwise, check will be a dead-end failure. Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
|
Thank you for your contribution to Apache Doris. |
Contributor
|
run buildall |
gavinchou
requested changes
Mar 12, 2024
Comment on lines
+454
to
+464
| try (AutoCloseConnectContext r = buildConnectContext()) { | ||
| r.connectContext.setCloudCluster(); | ||
| for (OlapTable table : statsTbls) { | ||
| for (Partition partition : table.getPartitions()) { | ||
| if (partition.getBaseIndex().getTablets().stream() | ||
| .anyMatch(t -> t.getNormalReplicaBackendIds().isEmpty())) { | ||
| return false; | ||
| } | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| try (AutoCloseConnectContext r = buildConnectContext()) { | |
| r.connectContext.setCloudCluster(); | |
| for (OlapTable table : statsTbls) { | |
| for (Partition partition : table.getPartitions()) { | |
| if (partition.getBaseIndex().getTablets().stream() | |
| .anyMatch(t -> t.getNormalReplicaBackendIds().isEmpty())) { | |
| return false; | |
| } | |
| } | |
| } | |
| } | |
| r.connectContext.getCloudCluster(); |
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Contributor
Author
|
run buildall |
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Contributor
Author
|
run buildall |
gavinchou
approved these changes
Mar 12, 2024
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 36964 ms |
TPC-DS: Total hot run time: 187423 ms |
ClickBench: Total hot run time: 29.67 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatisticsCollector only collect when replicas are normal. In cloud mode, this check needs getCloudCluster before execution. Otherwise, check will be a dead-end failure.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...