[Bug](top-n) do not update topn filter when sort node and scan node are not in the…#32159
Merged
dataroaring merged 2 commits intoapache:masterfrom Mar 13, 2024
Merged
[Bug](top-n) do not update topn filter when sort node and scan node are not in the…#32159dataroaring merged 2 commits intoapache:masterfrom
dataroaring merged 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37139 ms |
TPC-DS: Total hot run time: 186994 ms |
ClickBench: Total hot run time: 30.11 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
yiguolei
reviewed
Mar 13, 2024
be/src/runtime/runtime_predicate.h
Outdated
| } | ||
|
|
||
| bool need_update() const { | ||
| std::unique_lock<std::shared_mutex> wlock(_rwlock); |
Contributor
There was a problem hiding this comment.
why name wlock? actuall it is a readlock
Contributor
Author
|
run buildall |
yiguolei
approved these changes
Mar 13, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 36907 ms |
TPC-DS: Total hot run time: 185899 ms |
ClickBench: Total hot run time: 30.24 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… same backend
Proposed changes
do not update topn filter when sort node and scan node are not in the same backend
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...