Skip to content

[fix](cloud) Fix missing disk and cpu report in cloud mode#32424

Merged
dataroaring merged 1 commit intoapache:masterfrom
gavinchou:gavin-fix-cloud-missing-cpu-report
Mar 19, 2024
Merged

[fix](cloud) Fix missing disk and cpu report in cloud mode#32424
dataroaring merged 1 commit intoapache:masterfrom
gavinchou:gavin-fix-cloud-missing-cpu-report

Conversation

@gavinchou
Copy link
Contributor

Missing CPU reports may result in an incorrect PipelineExecutorSize (fixed to 1), affecting execution performance.

Reference code path of FE

getMinPipelineExecutorSize -> Backend.getPipelineExecutorSize 
public boolean updateCpuInfo(int cpuCores, int pipelineExecutorSize)
private static void cpuReport(long backendId, int cpuCores, int pipelineExecutorSize)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring changed the title (cloud) Fix missing disk and cpu report in cloud mode [fix](cloud) Fix missing disk and cpu report in cloud mode Mar 18, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 18, 2024
@gavinchou
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.24% (8701/24688)
Line Coverage: 27.07% (71183/262926)
Region Coverage: 26.32% (36918/140270)
Branch Coverage: 23.24% (18888/81268)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5307544923525b8915b949550ce908713abf3c25_5307544923525b8915b949550ce908713abf3c25/report/index.html

@dataroaring dataroaring merged commit cc4893f into apache:master Mar 19, 2024
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments