Skip to content

[Fix](Regression) DCHECK failed in runtime filter wrapper #32446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HappenLee merged 1 commit into from
Mar 19, 2024
Merged

[Fix](Regression) DCHECK failed in runtime filter wrapper #32446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions be/src/vec/exprs/vruntimefilter_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,15 @@ Status VRuntimeFilterWrapper::execute(VExprContext* context, Block* block, int*
ColumnWithTypeAndName& result_column = block->get_by_position(*result_column_id);
if (is_column_const(*result_column.column)) {
auto* constant_val = const_cast<char*>(result_column.column->get_data_at(0).data);
auto filter = constant_val == nullptr && reinterpret_cast<const int8_t*>(constant_val);
auto filter =
(constant_val == nullptr) || (!reinterpret_cast<const uint8_t*>(constant_val));
// if _null_aware is true, we should check the first args column is nullable. if value in
// column is null. we should set it to true
if (_null_aware) {
DCHECK(!args.empty());
DCHECK(is_column_const(*block->get_by_position(args[0]).column));
// if args is only null, result may be const null column
DCHECK(is_column_const(*block->get_by_position(args[0]).column) ||
constant_val == nullptr);
if (filter &&
block->get_by_position(args[0]).column->get_data_at(0).data == nullptr) {
auto res_col = ColumnVector<uint8_t>::create(1, 1);
Expand Down