Skip to content

[fix](merge-cloud) Fix CloudPartition.getVisibleVersion return value#32479

Merged
dataroaring merged 1 commit intoapache:masterfrom
w41ter:fix_empty_table_in_cloud_partition
Mar 20, 2024
Merged

[fix](merge-cloud) Fix CloudPartition.getVisibleVersion return value#32479
dataroaring merged 1 commit intoapache:masterfrom
w41ter:fix_empty_table_in_cloud_partition

Conversation

@w41ter
Copy link
Contributor

@w41ter w41ter commented Mar 19, 2024

Proposed changes

Issue Number: close #xxx

The return value of Partition.getVisibleVersion is 1 if the partition is empty, this PR unifies the behaviors between Partition and CloudPartition.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

The return value of Partition.getVisibleVersion is 1 if the partition
is empty, this PR unifies the behaviors between Partition and CloudPartition.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@w41ter
Copy link
Contributor Author

w41ter commented Mar 19, 2024

run buildall

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 794becb into apache:master Mar 20, 2024
@w41ter w41ter deleted the fix_empty_table_in_cloud_partition branch March 21, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants