Skip to content

[Chore](build) fix compile failed on SegmentFlusher::_expand_variant_to_subcolumns#32505

Merged
BiteTheDDDDt merged 2 commits intoapache:masterfrom
BiteTheDDDDt:fix_0320
Mar 20, 2024
Merged

[Chore](build) fix compile failed on SegmentFlusher::_expand_variant_to_subcolumns#32505
BiteTheDDDDt merged 2 commits intoapache:masterfrom
BiteTheDDDDt:fix_0320

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Mar 20, 2024 •
edited
Loading

Proposed changes

  1. fix compile failed on SegmentFlusher::_expand_variant_to_subcolumns
  2. revert [refactor](executor)Delete cpu_resource_limit #32388

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Mar 20, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 20, 2024

run buildall

eldenmoon
eldenmoon previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Mar 20, 2024

TeamCity be ut coverage result:
Function Coverage: 35.32% (8728/24714)
Line Coverage: 27.11% (71389/263286)
Region Coverage: 26.36% (37046/140538)
Branch Coverage: 23.27% (18942/81418)
Coverage Report: http://coverage.selectdb-in.cc/coverage/36840d68ec61d7e8d0c9f541ee62a5d1976606a7_36840d68ec61d7e8d0c9f541ee62a5d1976606a7/report/index.html

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 20, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Mar 20, 2024

TeamCity be ut coverage result:
Function Coverage: 35.30% (8725/24720)
Line Coverage: 27.09% (71340/263323)
Region Coverage: 26.35% (37032/140560)
Branch Coverage: 23.25% (18932/81430)
Coverage Report: http://coverage.selectdb-in.cc/coverage/50a8044c5feacb223ff3b6259cfa0c41b76c5d3b_50a8044c5feacb223ff3b6259cfa0c41b76c5d3b/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024

PR approved by at least one committer and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 37d4ec4 into apache:master Mar 20, 2024
@morrySnow morrySnow mentioned this pull request Mar 20, 2024
Closed
seawinde pushed a commit to seawinde/doris that referenced this pull request Mar 20, 2024
@BiteTheDDDDt @seawinde
[Chore](build) fix compile failed on SegmentFlusher::_expand_variant_…
23eda5c 
…to_subcolumns (apache#32505)

* fix compile failed on SegmentFlusher::_expand_variant_to_subcolumns

* Revert "[refactor](executor)Delete cpu_resource_limit (apache#32388)"

This reverts commit 3507274.
@BiteTheDDDDt BiteTheDDDDt deleted the fix_0320 branch January 20, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

@eldenmoon eldenmoon eldenmoon left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BiteTheDDDDt @doris-robot @morningman @Gabriel39 @zclllyybb @eldenmoon @yiguolei