Skip to content

[enhancement](statistics) excluded delta rows num for rollup tablets #32535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hastyshell wants to merge 1 commit into from
Closed

[enhancement](statistics) excluded delta rows num for rollup tablets #32535

Hastyshell wants to merge 1 commit into from

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Mar 20, 2024 •
edited
Loading

Proposed changes

As title. Just record delta rows num for base tablets.

Co-author in #32568. Close this draft.

@doris-robot
Copy link

doris-robot commented Mar 20, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Hastyshell Hastyshell force-pushed the loaded-rows-exclude-rollup branch from 4c64d62 to b60fcf9 Compare March 20, 2024 08:21
@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Mar 20, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Mar 20, 2024

TeamCity be ut coverage result:
Function Coverage: 35.30% (8730/24730)
Line Coverage: 27.09% (71403/263531)
Region Coverage: 26.34% (37063/140707)
Branch Coverage: 23.24% (18942/81514)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b60fcf9a389b2176947993de500d8fb93ed41cbb_b60fcf9a389b2176947993de500d8fb93ed41cbb/report/index.html

freemandealer
freemandealer reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@freemandealer freemandealer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution is LGTM, please complete this PR as well as regressions. Thanks!

freemandealer
freemandealer reviewed Mar 20, 2024
View reviewed changes
gensrc/thrift/AgentService.thrift Outdated
// strict mode means BE will check tablet missing version
3: optional bool strict_mode = false
// for delta rows statistics to exclude rollup tablets
4: optional set<Types.TTabletId> rollup_tablet_ids
Copy link
Contributor

@freemandealer freemandealer Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use base_index_tablet_ids instead? to save msg space and more accurate

Copy link
Collaborator Author

@Hastyshell Hastyshell Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified. Make it more accurate.

@Hastyshell Hastyshell force-pushed the loaded-rows-exclude-rollup branch from b60fcf9 to 70e59e3 Compare March 20, 2024 11:32
@Hastyshell Hastyshell closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@freemandealer freemandealer freemandealer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hastyshell @doris-robot @freemandealer