Skip to content

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Mar 28, 2024

for auto partition, support nullable partition column.
for auto list partition, support create real null partition for null values.
for auto range partition, null value will raise a error now. but maybe we can improve this in the future

Proposed changes

Issue Number: close #xxx

pick #31827

if merge this, need merge pick-pr of #32737 too

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

    for auto partition, support nullable partition column.
    for auto list partition, support create real null partition for null values.
    for auto range partition, null value will raise a error now. but maybe we can improve this in the future
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb zclllyybb changed the title [Feature](partition) Support OLAP table null partition (#31827) [branch-2.1](partition) Support OLAP table null partition (#31827) Mar 28, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

}
// NOLINTEND(readability-function-size)

Status VOlapTablePartitionParam::_create_partition_keys(const std::vector<TExprNode>& t_exprs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: method '_create_partition_keys' can be made static [readability-convert-member-functions-to-static]

Suggested change
Status VOlapTablePartitionParam::_create_partition_keys(const std::vector<TExprNode>& t_exprs,
static Status VOlapTablePartitionParam::_create_partition_keys(const std::vector<TExprNode>& t_exprs,


#pragma once

#include <glog/logging.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'glog/logging.h' file not found [clang-diagnostic-error]

#include <glog/logging.h>
         ^

@zclllyybb zclllyybb marked this pull request as draft March 28, 2024 15:03
@zclllyybb zclllyybb changed the title [branch-2.1](partition) Support OLAP table null partition (#31827) [branch-2.1.2](partition) Support OLAP table null partition (#31827) Mar 28, 2024
@zclllyybb
Copy link
Contributor Author

wait 2.1.2

@zclllyybb zclllyybb closed this Apr 10, 2024
@zclllyybb zclllyybb deleted the pick_nullrange branch April 10, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants