Skip to content

[pipelineX](fix) Fix coredump by incorrect cancel order#33294

Merged
yiguolei merged 2 commits intoapache:masterfrom
Gabriel39:fix_0407
Apr 7, 2024
Merged

[pipelineX](fix) Fix coredump by incorrect cancel order#33294
yiguolei merged 2 commits intoapache:masterfrom
Gabriel39:fix_0407

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Apr 7, 2024

Proposed changes

*** Query id: 8c6c8b72147840e0-bc9376ccdbda18a0 ***
17:58:59  *** is nereids: 1 ***
17:58:59  *** tablet id: 0 ***
17:58:59  *** Aborted at 1712397259 (unix time) try "date -d @1712397259" if you are using GNU date ***
17:58:59  *** Current BE git commitID: c5fff3b ***
17:58:59  *** SIGABRT unknown detail explain (@0x3408) received by PID 13320 (TID 15501 OR 0x7f2c3bae5700) from PID 13320; stack trace: ***
17:58:59  0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:421
17:58:59  1# 0x00007F2CF9872090 in /lib/x86_64-linux-gnu/libc.so.6
17:58:59  2# raise at ../sysdeps/unix/sysv/linux/raise.c:51
17:58:59  3# abort at /build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81
17:58:59  4# 0x0000565277D9DF9D in /mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be
17:58:59  5# google::LogMessage::SendToLog() in /mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be
17:58:59  6# google::LogMessage::Flush() in /mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be
17:58:59  7# google::LogMessageFatal::~LogMessageFatal() in /mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be
17:58:59  8# 0x0000565277832C5F at /root/doris/be/src/pipeline/pipeline_x/local_exchange/local_exchange_sink_operator.cpp:49
17:58:59  9# doris::pipeline::DataSinkOperatorXBase::close(doris::RuntimeState*, doris::Status) at /root/doris/be/src/pipeline/pipeline_x/operator.h:655
17:58:59  10# doris::pipeline::PipelineXTask::close(doris::Status) at /root/doris/be/src/pipeline/pipeline_x/pipeline_x_task.cpp:380
17:58:59  11# doris::pipeline::_close_task(doris::pipeline::PipelineTask*, doris::pipeline::PipelineTaskState, doris::Status) at /root/doris/be/src/pipeline/task_scheduler.cpp:242
17:58:59  12# doris::pipeline::TaskScheduler::_do_work(unsigned long) at /root/doris/be/src/pipeline/task_scheduler.cpp:300
17:58:59  13# doris::ThreadPool::dispatch_thread() at /root/doris/be/src/util/threadpool.cpp:551
17:58:59  14# doris::Thread::supervise_thread(void*) at /root/doris/be/src/util/thread.cpp:499
17:58:59  15# start_thread at /build/glibc-SzIz7B/glibc-2.31/nptl/pthread_create.c:478
17:58:59  16# __clone at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.64% (8887/24932)
Line Coverage: 27.38% (72973/266487)
Region Coverage: 26.56% (37726/142037)
Branch Coverage: 23.36% (19223/82306)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4643bb12b48a73876f46e02d54a62036cc22d16c_4643bb12b48a73876f46e02d54a62036cc22d16c/report/index.html

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38614 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4643bb12b48a73876f46e02d54a62036cc22d16c, data reload: false

------ Round 1 ----------------------------------
q1	17606	4060	4062	4060
q2	2009	185	186	185
q3	10482	1145	1285	1145
q4	10200	807	990	807
q5	7473	2994	2932	2932
q6	219	134	134	134
q7	1115	625	606	606
q8	9419	1884	2041	1884
q9	6696	6212	6162	6162
q10	8474	3545	3540	3540
q11	424	245	242	242
q12	382	219	216	216
q13	19271	2913	2949	2913
q14	274	242	244	242
q15	524	495	487	487
q16	503	384	377	377
q17	952	924	898	898
q18	7317	6504	6510	6504
q19	1595	1537	1536	1536
q20	548	313	306	306
q21	3563	3151	3131	3131
q22	369	316	307	307
Total cold run time: 109415 ms
Total hot run time: 38614 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4106	4083	4143	4083
q2	333	240	222	222
q3	2966	2982	2983	2982
q4	1923	1989	1980	1980
q5	5437	5431	5447	5431
q6	214	130	130	130
q7	2355	1977	1990	1977
q8	3261	3372	3324	3324
q9	8655	8660	8627	8627
q10	3941	4040	3992	3992
q11	574	470	479	470
q12	795	637	614	614
q13	18481	3097	3105	3097
q14	312	280	267	267
q15	518	492	482	482
q16	506	422	402	402
q17	1733	1707	1738	1707
q18	8094	7708	7640	7640
q19	1678	1669	1682	1669
q20	2049	1803	1791	1791
q21	5201	4905	4980	4905
q22	519	450	449	449
Total cold run time: 73651 ms
Total hot run time: 56241 ms

@yiguolei
Copy link
Contributor

yiguolei commented Apr 7, 2024

run buildall

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.64% (8885/24932)
Line Coverage: 27.38% (72965/266487)
Region Coverage: 26.55% (37709/142037)
Branch Coverage: 23.35% (19219/82306)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a79d73341d65c7717d39ca434d0f32d2134a3de3_a79d73341d65c7717d39ca434d0f32d2134a3de3/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 38488 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a79d73341d65c7717d39ca434d0f32d2134a3de3, data reload: false

------ Round 1 ----------------------------------
q1	17669	4216	4235	4216
q2	1992	171	170	170
q3	10524	1152	1347	1152
q4	10212	845	949	845
q5	7478	2959	2926	2926
q6	214	129	131	129
q7	1073	632	600	600
q8	9407	2056	2036	2036
q9	6721	6200	6136	6136
q10	8443	3504	3492	3492
q11	421	234	236	234
q12	395	206	203	203
q13	17783	2881	2880	2880
q14	272	237	240	237
q15	509	468	469	468
q16	517	402	375	375
q17	944	916	873	873
q18	7251	6440	6311	6311
q19	1660	1534	1533	1533
q20	547	307	297	297
q21	3461	3111	3080	3080
q22	354	297	295	295
Total cold run time: 107847 ms
Total hot run time: 38488 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4042	4045	4020	4020
q2	328	217	217	217
q3	2945	2913	2924	2913
q4	1842	1831	1807	1807
q5	5223	5198	5200	5198
q6	207	121	120	120
q7	2226	1777	1826	1777
q8	3222	3246	3253	3246
q9	8458	8460	8465	8460
q10	3721	3860	3863	3860
q11	547	436	452	436
q12	693	528	537	528
q13	16813	2886	2884	2884
q14	280	260	250	250
q15	509	464	462	462
q16	459	400	403	400
q17	1691	1658	1644	1644
q18	7531	7673	7702	7673
q19	1690	1696	1674	1674
q20	2044	1867	1883	1867
q21	5161	4878	4866	4866
q22	518	436	452	436
Total cold run time: 70150 ms
Total hot run time: 54738 ms

@yiguolei yiguolei merged commit 3f98b1f into apache:master Apr 7, 2024
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants