Skip to content

[enhance](cloud) Implement FullRangeGetIterator to simplify iterating over a kv range#33388

Merged
dataroaring merged 1 commit intoapache:masterfrom
platoneko:full-iterator
Jun 11, 2024
Merged

[enhance](cloud) Implement FullRangeGetIterator to simplify iterating over a kv range#33388
dataroaring merged 1 commit intoapache:masterfrom
platoneko:full-iterator

Conversation

@platoneko
Copy link
Contributor

Proposed changes

Implement FullRangeGetIterator to simplify iterating over a kv range

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

}
}

TEST(TxnKvTest, FullRangeGetIterator) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]

TEST(TxnKvTest, FullRangeGetIterator) {
^
Additional context

cloud/test/txn_kv_test.cpp:552: 255 lines including whitespace and comments (threshold 80)

TEST(TxnKvTest, FullRangeGetIterator) {
^

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

}
}

TEST(TxnKvTest, FullRangeGetIterator) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]

TEST(TxnKvTest, FullRangeGetIterator) {
^
Additional context

cloud/test/txn_kv_test.cpp:552: 257 lines including whitespace and comments (threshold 80)

TEST(TxnKvTest, FullRangeGetIterator) {
^

@platoneko platoneko requested a review from gavinchou June 6, 2024 06:06
@dataroaring
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 11, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 26e117d into apache:master Jun 11, 2024
dataroaring pushed a commit that referenced this pull request Jun 13, 2024
… over a kv range (#33388)

Implement FullRangeGetIterator to simplify iterating over a kv range

## Further comments

If this is a relatively large or complex change, kick off the discussion
at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why
you chose the solution you did and what alternatives you considered,
etc...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants