Skip to content

[fix](Cloud) Set correct thdfs params's fields#33392

Merged
dataroaring merged 3 commits into
apache:masterfrom
ByteYue:set_correct_thdfs_params
Apr 9, 2024
Merged

[fix](Cloud) Set correct thdfs params's fields#33392
dataroaring merged 3 commits into
apache:masterfrom
ByteYue:set_correct_thdfs_params

Conversation

@ByteYue
Copy link
Copy Markdown
Contributor

@ByteYue ByteYue commented Apr 8, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented Apr 8, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Apr 8, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.59% (8889/24976)
Line Coverage: 27.33% (72985/267012)
Region Coverage: 26.50% (37724/142348)
Branch Coverage: 23.31% (19221/82468)
Coverage Report: http://coverage.selectdb-in.cc/coverage/00c0a1f10c6ed9f43e60618da975e775d4fb0081_00c0a1f10c6ed9f43e60618da975e775d4fb0081/report/index.html

Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 60212da into apache:master Apr 9, 2024
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 10, 2024
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants