Skip to content

[bugfix](deadlock) should not use query cancelled in fragment mgr#33422

Merged
yiguolei merged 3 commits intoapache:masterfrom
yiguolei:fix_dl
Apr 9, 2024
Merged

[bugfix](deadlock) should not use query cancelled in fragment mgr#33422
yiguolei merged 3 commits intoapache:masterfrom
yiguolei:fix_dl

Conversation

@yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Apr 9, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yiguolei
Copy link
Contributor Author

yiguolei commented Apr 9, 2024

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yiguolei
Copy link
Contributor Author

yiguolei commented Apr 9, 2024

run buildall

xinyiZzz
xinyiZzz previously approved these changes Apr 9, 2024
Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Contributor Author

yiguolei commented Apr 9, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 9, 2024
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.64% (8905/24989)
Line Coverage: 27.37% (73146/267216)
Region Coverage: 26.54% (37793/142421)
Branch Coverage: 23.35% (19261/82504)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6d47247065c8e50b9bf10b802c6d30cdd4fd9ae4_6d47247065c8e50b9bf10b802c6d30cdd4fd9ae4/report/index.html

@yiguolei yiguolei merged commit b38be5f into apache:master Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants