[Fix](hive-writer) Cherry pick 32721,32775.#33443
Closed
kaka11chen wants to merge 2 commits intoapache:2.1-tmpfrom
Closed
[Fix](hive-writer) Cherry pick 32721,32775.#33443kaka11chen wants to merge 2 commits intoapache:2.1-tmpfrom
kaka11chen wants to merge 2 commits intoapache:2.1-tmpfrom
Conversation
…ed by refactoring and add hive writing regression test. (apache#32721) Issue Number: apache#31442 - Fix the issue of not initializing the writer caused by refactoring code in apache#31716. - Fix reference lifetime issue of `TParquetVersion::type parquet_version` in `VParquetTransformer ` when using temp object. - Add hive writing regression tests.
…ing when hive partition writer write block to file. (apache#32775)
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Status st = _vfile_writer->close(); | ||
| if (st != Status::OK()) { | ||
| LOG(WARNING) << fmt::format("_vfile_writer close failed, reason: {}", st.to_string()); | ||
| Status VHivePartitionWriter::close(const Status& status) { |
Contributor
There was a problem hiding this comment.
warning: method 'close' can be made static [readability-convert-member-functions-to-static]
be/src/vec/sink/writer/vhive_partition_writer.h:58:
- Status close(const Status& status);
+ static Status close(const Status& status);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Cherry pick #32721 #32775.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...