Skip to content

[fix](memory) Fix memtable flush memory tracking #33929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xinyiZzz merged 1 commit into from
Apr 20, 2024
Merged

[fix](memory) Fix memtable flush memory tracking #33929

xinyiZzz merged 1 commit into from
Apr 20, 2024

Conversation

@xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Apr 20, 2024 •
edited
Loading

Proposed changes

fix:

F20240420 12:47:23.222411 31558 thread_context.h:164] Check failed: thread_mem_tracker()->label() == "Orphan" , thread mem tracker label: Load#Id=b43f342ae5564c23-b7b41daf24545f78, attach mem tracker label: Load#Id=4241cef180013366-1ba9f658007f339a
12:49:46   *** Check failure stack trace: ***
12:49:46       @     0x55584aae5d26  google::LogMessage::SendToLog()
12:49:46       @     0x55584aae2770  google::LogMessage::Flush()
12:49:46       @     0x55584aae6569  google::LogMessageFatal::~LogMessageFatal()
12:49:46       @     0x55581abce4ae  doris::ThreadContext::attach_task()
12:49:46       @     0x55581abc8e8e  doris::AttachTask::AttachTask()
12:49:46       @     0x5558170a055b  doris::MemTableWriter::flush_async()
12:49:46       @     0x5558170604ee  doris::MemTableMemoryLimiter::_flush_memtable()
12:49:46       @     0x55581705e8e6  doris::MemTableMemoryLimiter::_flush_active_memtables()
12:49:46       @     0x55581705d986  doris::MemTableMemoryLimiter::handle_memtable_flush()
12:49:46       @     0x555848c9a36d  doris::vectorized::VTabletWriterV2::_write_memtable()
12:49:46       @     0x555848c990c8  doris::vectorized::VTabletWriterV2::write()
12:49:46       @     0x555848b48b5e  doris::vectorized::AsyncResultWriter::process_block()
12:49:46       @     0x555848b4be49  doris::vectorized::AsyncResultWriter::start_writer()::$_0::operator()()

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Apr 20, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Apr 20, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2024

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz xinyiZzz force-pushed the 20240420_fix_memtable_flush_trackingr branch from 7f09437 to 6a93a6f Compare April 20, 2024 14:37
@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Apr 20, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Apr 20, 2024

TeamCity be ut coverage result:
Function Coverage: 35.39% (8922/25208)
Line Coverage: 27.10% (73315/270532)
Region Coverage: 26.24% (37875/144356)
Branch Coverage: 23.04% (19282/83682)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6a93a6f91e5c5191234ee38e8913eab8c2841842_6a93a6f91e5c5191234ee38e8913eab8c2841842/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2024

PR approved by anyone and no changes requested.

zhiqiang-hhhh
zhiqiang-hhhh approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mrhhsg
mrhhsg approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz xinyiZzz merged commit 4697544 into apache:master Apr 20, 2024
yiguolei pushed a commit that referenced this pull request Apr 21, 2024
@xinyiZzz @Doris-Extras
[bugfix](memtracker) memtracker is attached duplicately (#33929)
cb2598e 
fix:

F20240420 12:47:23.222411 31558 thread_context.h:164] Check failed: thread_mem_tracker()->label() == "Orphan" , thread mem tracker label: Load#Id=b43f342ae5564c23-b7b41daf24545f78, attach mem tracker label: Load#Id=4241cef180013366-1ba9f658007f339a
12:49:46   *** Check failure stack trace: ***
12:49:46       @     0x55584aae5d26  google::LogMessage::SendToLog()
12:49:46       @     0x55584aae2770  google::LogMessage::Flush()
12:49:46       @     0x55584aae6569  google::LogMessageFatal::~LogMessageFatal()
12:49:46       @     0x55581abce4ae  doris::ThreadContext::attach_task()
12:49:46       @     0x55581abc8e8e  doris::AttachTask::AttachTask()
12:49:46       @     0x5558170a055b  doris::MemTableWriter::flush_async()
12:49:46       @     0x5558170604ee  doris::MemTableMemoryLimiter::_flush_memtable()
12:49:46       @     0x55581705e8e6  doris::MemTableMemoryLimiter::_flush_active_memtables()
12:49:46       @     0x55581705d986  doris::MemTableMemoryLimiter::handle_memtable_flush()
12:49:46       @     0x555848c9a36d  doris::vectorized::VTabletWriterV2::_write_memtable()
12:49:46       @     0x555848c990c8  doris::vectorized::VTabletWriterV2::write()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrhhsg mrhhsg mrhhsg approved these changes

@yiguolei yiguolei yiguolei approved these changes

+1 more reviewer

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xinyiZzz @doris-robot @mrhhsg @yiguolei @zhiqiang-hhhh