[fix](nereids)prevent null pointer access if translate expression fails#34055
Merged
starocean999 merged 1 commit intoapache:branch-2.0from Apr 26, 2024
Merged
[fix](nereids)prevent null pointer access if translate expression fails#34055starocean999 merged 1 commit intoapache:branch-2.0from
starocean999 merged 1 commit intoapache:branch-2.0from
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 49718 ms |
TPC-DS: Total hot run time: 203476 ms |
ClickBench: Total hot run time: 30.56 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
|
can you add some test case? |
Contributor
Author
I found the NPE in some unexpected scenario. Like user defined var is not replaced by literal in right place would cause the translation fail. After the bug is fixed, there is not NPE now. So this is just a fail-safe for unexpected fail in future. |
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
pick from master #33990
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...