Skip to content

[Improvement](pipeline) Use hash shuffle for 1-phase Agg/Analytic operator#34075

Closed
Gabriel39 wants to merge 6 commits intoapache:masterfrom
Gabriel39:imp_0424
Closed

[Improvement](pipeline) Use hash shuffle for 1-phase Agg/Analytic operator#34075
Gabriel39 wants to merge 6 commits intoapache:masterfrom
Gabriel39:imp_0424

Conversation

@Gabriel39
Copy link
Contributor

Proposed changes

For 1-phase Agg/Analytic operator, we prefer to use hash shuffle instead of bucket shuffle which is restricted by bucket distribution.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.20% (8916/25329)
Line Coverage: 26.98% (73338/271825)
Region Coverage: 26.15% (37873/144847)
Branch Coverage: 22.97% (19284/83954)
Coverage Report: http://coverage.selectdb-in.cc/coverage/af165dc22f7b3706367d480b495c05ce516e4232_af165dc22f7b3706367d480b495c05ce516e4232/report/index.html

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.19% (8918/25345)
Line Coverage: 26.97% (73321/271883)
Region Coverage: 26.14% (37873/144900)
Branch Coverage: 22.96% (19283/83992)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f1da0eb70410ae35f6df4f8598170771b006e89e_f1da0eb70410ae35f6df4f8598170771b006e89e/report/index.html

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.19% (8918/25345)
Line Coverage: 26.97% (73335/271887)
Region Coverage: 26.14% (37883/144903)
Branch Coverage: 22.97% (19294/83994)
Coverage Report: http://coverage.selectdb-in.cc/coverage/90dca98c9238f1b055e6a9e1c3cfe4de412c9b7b_90dca98c9238f1b055e6a9e1c3cfe4de412c9b7b/report/index.html

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.18% (8917/25345)
Line Coverage: 26.97% (73325/271887)
Region Coverage: 26.14% (37876/144903)
Branch Coverage: 22.96% (19286/83996)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0ac9c7727fcccd25da3fb25f7f98dd402e61e70b_0ac9c7727fcccd25da3fb25f7f98dd402e61e70b/report/index.html

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.19% (8918/25345)
Line Coverage: 26.97% (73318/271888)
Region Coverage: 26.14% (37875/144903)
Branch Coverage: 22.96% (19287/83996)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2c66ebfdc71cb7c0227f140674002ffbe3b9ebc2_2c66ebfdc71cb7c0227f140674002ffbe3b9ebc2/report/index.html

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Gabriel39 Gabriel39 closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants