Skip to content

[feature](Cloud) Implement gcs accessor for compatibility#34081

Merged
dataroaring merged 2 commits intoapache:masterfrom
ByteYue:gcp_accessor
Apr 25, 2024
Merged

[feature](Cloud) Implement gcs accessor for compatibility#34081
dataroaring merged 2 commits intoapache:masterfrom
ByteYue:gcp_accessor

Conversation

@ByteYue
Copy link
Contributor

@ByteYue ByteYue commented Apr 24, 2024

Proposed changes

Issue Number: close #xxx

GCP doesn't support DeleteObjects so we use parallel delete object for GCP.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@ByteYue
Copy link
Contributor Author

ByteYue commented Apr 24, 2024

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring previously approved these changes Apr 24, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 24, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@ByteYue
Copy link
Contributor Author

ByteYue commented Apr 24, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 24, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 8ffb170 into apache:master Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants