[opt](memory) BE memory info compatible with Cgroup #34262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41565 ms |
TPC-DS: Total hot run time: 185866 ms |
TPC-H: Total hot run time: 40791 ms |
TPC-DS: Total hot run time: 185781 ms |
yiguolei
reviewed
May 6, 2024
be/src/util/mem_info.cpp
Outdated
| if (_s_physical_mem == -1) { | ||
| LOG(WARNING) << "Could not determine amount of physical memory on this machine."; | ||
| // 2. if physical_mem changed, refresh mem limit and gc size. | ||
| if (_s_physical_mem.load(std::memory_order_relaxed) != physical_mem) { |
Contributor
There was a problem hiding this comment.
should check physical_mem > 0.
Because if it == -1, then the following logic after 410 is wrong.
xinyiZzz
force-pushed
the
20240424_fix_cgroup_mem
branch
from
a884604 to
074297d
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-DS: Total hot run time: 189242 ms |
|
TeamCity be ut coverage result: |
yiguolei
approved these changes
May 6, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Gabriel39
approved these changes
May 6, 2024
Contributor
|
PR approved by anyone and no changes requested. |
|
When testing out this change, we're getting the following errors on Mac OS Docker. |
ByteYue
pushed a commit
to ByteYue/doris
that referenced
this pull request
May 15, 2024
Contributor
Author
Hi @geoffreytran, i found this problem, will fix it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
reproduction steps:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...