Skip to content

Conversation

@BiteTheDDDDt
Copy link
Contributor

Proposed changes

release rf count dependency when query canceled

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.68% (8954/25092)
Line Coverage: 27.28% (73841/270699)
Region Coverage: 26.46% (38138/144146)
Branch Coverage: 23.22% (19430/83684)
Coverage Report: http://coverage.selectdb-in.cc/coverage/56f460bc2cba472e5a7c14670a2ceb92731c671f_56f460bc2cba472e5a7c14670a2ceb92731c671f/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40965 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 56f460bc2cba472e5a7c14670a2ceb92731c671f, data reload: false

------ Round 1 ----------------------------------
q1	17966	5134	4287	4287
q2	2021	191	187	187
q3	10641	1262	1274	1262
q4	10367	859	783	783
q5	7665	2708	2688	2688
q6	219	132	139	132
q7	1039	634	601	601
q8	9481	2130	2115	2115
q9	9277	6743	6688	6688
q10	9141	3695	3703	3695
q11	480	236	237	236
q12	412	227	213	213
q13	17763	2967	2963	2963
q14	266	210	216	210
q15	500	465	459	459
q16	516	384	371	371
q17	966	666	723	666
q18	8097	7469	7440	7440
q19	4335	1533	1464	1464
q20	643	315	311	311
q21	5006	4130	3919	3919
q22	343	275	287	275
Total cold run time: 117144 ms
Total hot run time: 40965 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4319	4228	4220	4220
q2	373	268	270	268
q3	2986	2808	2742	2742
q4	1903	1638	1626	1626
q5	5356	5317	5334	5317
q6	215	127	127	127
q7	2311	1882	1907	1882
q8	3248	3381	3387	3381
q9	8567	8531	8524	8524
q10	3971	3682	3728	3682
q11	586	503	497	497
q12	780	616	610	610
q13	16363	2954	2972	2954
q14	304	276	259	259
q15	523	480	473	473
q16	467	417	412	412
q17	1775	1486	1483	1483
q18	7513	7578	7451	7451
q19	1719	1572	1589	1572
q20	1974	1761	1769	1761
q21	5158	4900	4905	4900
q22	588	492	510	492
Total cold run time: 70999 ms
Total hot run time: 54633 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185584 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 56f460bc2cba472e5a7c14670a2ceb92731c671f, data reload: false

query1	932	359	346	346
query2	6450	2349	2340	2340
query3	6654	204	204	204
query4	23219	21200	21374	21200
query5	4191	433	419	419
query6	264	176	168	168
query7	4592	285	284	284
query8	238	187	204	187
query9	8515	2351	2330	2330
query10	429	248	250	248
query11	14698	14107	14118	14107
query12	145	94	88	88
query13	1670	372	379	372
query14	9670	7560	7070	7070
query15	257	173	169	169
query16	8193	263	273	263
query17	1862	574	561	561
query18	2115	279	274	274
query19	203	158	155	155
query20	98	88	90	88
query21	201	129	131	129
query22	5179	4946	4885	4885
query23	34016	33314	33244	33244
query24	12000	2850	3027	2850
query25	664	383	376	376
query26	1755	155	147	147
query27	3012	329	315	315
query28	7571	2034	2044	2034
query29	1029	617	616	616
query30	308	151	155	151
query31	970	765	751	751
query32	100	58	57	57
query33	752	258	255	255
query34	1025	485	479	479
query35	823	697	678	678
query36	1078	903	922	903
query37	277	70	72	70
query38	3255	2961	2991	2961
query39	1643	1547	1573	1547
query40	279	128	126	126
query41	45	39	40	39
query42	104	96	98	96
query43	577	543	521	521
query44	1278	736	750	736
query45	271	229	258	229
query46	1076	759	718	718
query47	1933	1843	1851	1843
query48	431	295	295	295
query49	1195	397	397	397
query50	781	380	377	377
query51	6807	6633	6642	6633
query52	103	89	93	89
query53	354	279	278	278
query54	306	234	225	225
query55	76	70	71	70
query56	240	215	219	215
query57	1245	1109	1117	1109
query58	230	198	194	194
query59	3351	3335	3052	3052
query60	249	226	227	226
query61	88	88	89	88
query62	656	448	446	446
query63	304	283	275	275
query64	9610	7180	7222	7180
query65	3162	3072	3070	3070
query66	1384	336	340	336
query67	15560	15259	14946	14946
query68	9901	540	527	527
query69	603	348	318	318
query70	1406	1122	1109	1109
query71	511	270	271	270
query72	8460	2553	2358	2358
query73	1641	326	321	321
query74	6677	6101	6118	6101
query75	4978	2660	2657	2657
query76	5946	1051	1027	1027
query77	656	259	264	259
query78	11061	10251	10161	10161
query79	11998	517	511	511
query80	2457	442	429	429
query81	508	218	212	212
query82	232	97	93	93
query83	226	164	163	163
query84	263	81	82	81
query85	1123	270	262	262
query86	346	297	296	296
query87	3299	3064	3087	3064
query88	5292	2321	2334	2321
query89	526	385	367	367
query90	2060	187	183	183
query91	124	96	101	96
query92	57	47	47	47
query93	7356	516	506	506
query94	1408	183	180	180
query95	398	298	296	296
query96	620	271	259	259
query97	3143	2935	2964	2935
query98	242	227	222	222
query99	1230	850	823	823
Total cold run time: 316496 ms
Total hot run time: 185584 ms

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.69% (8958/25098)
Line Coverage: 27.28% (73890/270811)
Region Coverage: 26.47% (38174/144198)
Branch Coverage: 23.23% (19449/83716)
Coverage Report: http://coverage.selectdb-in.cc/coverage/94d00753033119d9ade85fb429bbb7e482ae087c_94d00753033119d9ade85fb429bbb7e482ae087c/report/index.html

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.69% (8958/25098)
Line Coverage: 27.29% (73898/270811)
Region Coverage: 26.48% (38177/144198)
Branch Coverage: 23.23% (19451/83716)
Coverage Report: http://coverage.selectdb-in.cc/coverage/94d00753033119d9ade85fb429bbb7e482ae087c_94d00753033119d9ade85fb429bbb7e482ae087c/report/index.html

yiguolei
yiguolei previously approved these changes May 1, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

PR approved by anyone and no changes requested.

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.69% (8958/25098)
Line Coverage: 27.28% (73889/270810)
Region Coverage: 26.47% (38168/144198)
Branch Coverage: 23.22% (19441/83716)
Coverage Report: http://coverage.selectdb-in.cc/coverage/94c1ad8a98573c35bdea5eb0bcc32c331c8ad7a5_94c1ad8a98573c35bdea5eb0bcc32c331c8ad7a5/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 41968 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 94c1ad8a98573c35bdea5eb0bcc32c331c8ad7a5, data reload: false

------ Round 1 ----------------------------------
q1	17600	4384	4257	4257
q2	2029	186	185	185
q3	10466	1224	1248	1224
q4	10193	837	737	737
q5	7536	2723	2682	2682
q6	219	137	136	136
q7	1040	599	611	599
q8	9245	2163	2121	2121
q9	9241	6782	6764	6764
q10	9154	3866	3796	3796
q11	495	244	244	244
q12	506	235	224	224
q13	18129	3230	3247	3230
q14	267	225	227	225
q15	532	477	468	468
q16	510	369	374	369
q17	964	692	700	692
q18	8345	7793	7771	7771
q19	1820	1562	1576	1562
q20	648	312	321	312
q21	5243	4092	4197	4092
q22	359	291	278	278
Total cold run time: 114541 ms
Total hot run time: 41968 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4586	4410	4370	4370
q2	375	269	261	261
q3	3144	2994	2946	2946
q4	1944	1632	1651	1632
q5	5441	5519	5471	5471
q6	212	125	124	124
q7	2373	1958	1991	1958
q8	3276	3435	3434	3434
q9	8673	8837	8841	8837
q10	3961	3769	3804	3769
q11	589	516	501	501
q12	793	648	628	628
q13	16174	3127	3123	3123
q14	292	270	259	259
q15	524	503	483	483
q16	496	431	425	425
q17	1787	1486	1461	1461
q18	7747	7604	7360	7360
q19	1698	1616	1526	1526
q20	2025	1759	1752	1752
q21	8418	4898	4894	4894
q22	572	494	493	493
Total cold run time: 75100 ms
Total hot run time: 55707 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184945 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 94c1ad8a98573c35bdea5eb0bcc32c331c8ad7a5, data reload: false

query1	920	355	358	355
query2	6444	2422	2256	2256
query3	6644	204	206	204
query4	24245	21155	21107	21107
query5	4169	424	417	417
query6	263	190	166	166
query7	4580	287	279	279
query8	239	188	179	179
query9	8498	2331	2322	2322
query10	450	246	267	246
query11	14755	14239	14232	14232
query12	134	95	94	94
query13	1650	385	377	377
query14	9766	6954	6668	6668
query15	247	168	181	168
query16	7871	266	271	266
query17	1716	572	565	565
query18	2012	278	280	278
query19	205	154	151	151
query20	94	88	85	85
query21	195	134	133	133
query22	5062	4874	4918	4874
query23	33721	33168	33107	33107
query24	9490	2822	2997	2822
query25	580	386	375	375
query26	698	153	150	150
query27	2207	315	327	315
query28	5831	1999	1997	1997
query29	867	611	598	598
query30	246	163	156	156
query31	978	754	700	700
query32	91	54	55	54
query33	629	255	249	249
query34	876	481	476	476
query35	763	701	669	669
query36	1045	947	920	920
query37	109	69	69	69
query38	3180	3000	2980	2980
query39	1584	1565	1551	1551
query40	194	128	134	128
query41	43	41	40	40
query42	104	97	95	95
query43	553	535	534	534
query44	1099	738	765	738
query45	275	259	264	259
query46	1074	725	731	725
query47	1976	1914	1909	1909
query48	370	308	302	302
query49	902	391	404	391
query50	773	389	374	374
query51	6631	6620	6635	6620
query52	98	94	85	85
query53	346	271	273	271
query54	277	232	224	224
query55	74	70	71	70
query56	249	223	217	217
query57	1201	1141	1133	1133
query58	217	200	194	194
query59	3362	3271	3142	3142
query60	267	238	233	233
query61	89	93	90	90
query62	600	453	470	453
query63	299	274	277	274
query64	8274	7223	7185	7185
query65	3096	3045	3056	3045
query66	768	352	369	352
query67	15773	14927	14854	14854
query68	9671	544	540	540
query69	566	308	307	307
query70	1403	1069	1129	1069
query71	473	269	272	269
query72	8185	2593	2314	2314
query73	1577	330	332	330
query74	6590	6129	6163	6129
query75	4460	2637	2626	2626
query76	5054	1051	899	899
query77	718	266	267	266
query78	11016	10104	10154	10104
query79	10947	510	502	502
query80	1813	431	421	421
query81	498	229	223	223
query82	175	90	96	90
query83	208	169	171	169
query84	272	89	83	83
query85	958	271	261	261
query86	347	270	304	270
query87	3273	3077	3147	3077
query88	5014	2459	2430	2430
query89	504	384	390	384
query90	2399	186	186	186
query91	125	98	97	97
query92	60	48	47	47
query93	5662	525	508	508
query94	1521	188	186	186
query95	425	314	319	314
query96	627	272	262	262
query97	3142	2962	2949	2949
query98	245	216	218	216
query99	1091	872	870	870
Total cold run time: 301057 ms
Total hot run time: 184945 ms

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit c151843 into apache:master May 2, 2024
yiguolei pushed a commit that referenced this pull request May 2, 2024
…#34367)

* release rf count dependency when query canceled

* update

* update
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
…apache#34367)

* release rf count dependency when query canceled

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants