Skip to content

[opt](func) opt the revert_null_map performance#34393

Merged
HappenLee merged 1 commit intoapache:masterfrom
HappenLee:pip
May 5, 2024
Merged

[opt](func) opt the revert_null_map performance#34393
HappenLee merged 1 commit intoapache:masterfrom
HappenLee:pip

Conversation

@HappenLee
Copy link
Contributor

Proposed changes

2024-05-04T23:54:46+08:00
Running ./benchmark
Run on (96 X 3100.01 MHz CPU s)
CPU Caches:
  L1 Data 32 KiB (x48)
  L1 Instruction 32 KiB (x48)
  L2 Unified 1024 KiB (x48)
  L3 Unified 36608 KiB (x2)
Load Average: 0.31, 1.20, 1.20
------------------------------------------------------
Benchmark            Time             CPU   Iterations
------------------------------------------------------
origin_test   10682025 ns     10682054 ns           55
simd_test       966283 ns       966286 ns          660

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@HappenLee
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-DS: Total hot run time: 183858 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 886a278f12c11da72ce2941b5fa26dec8c6982b9, data reload: false

query1	937	367	348	348
query2	6796	2254	2335	2254
query3	6670	211	210	210
query4	23371	21843	21979	21843
query5	3801	431	424	424
query6	279	178	174	174
query7	4580	289	282	282
query8	239	193	193	193
query9	8380	2409	2390	2390
query10	424	246	272	246
query11	11739	11215	11396	11215
query12	121	87	88	87
query13	1661	371	378	371
query14	10644	8440	8279	8279
query15	259	170	168	168
query16	8206	262	258	258
query17	1914	579	555	555
query18	2124	280	275	275
query19	321	153	153	153
query20	97	88	85	85
query21	195	127	126	126
query22	4945	4843	4818	4818
query23	34200	33073	33069	33069
query24	10588	2903	2844	2844
query25	606	385	376	376
query26	1123	150	149	149
query27	2508	316	322	316
query28	7020	2046	2022	2022
query29	874	629	619	619
query30	225	156	150	150
query31	941	773	714	714
query32	93	49	50	49
query33	736	243	240	240
query34	1040	473	466	466
query35	799	637	672	637
query36	1045	878	945	878
query37	133	64	68	64
query38	3097	2999	2969	2969
query39	1589	1659	1543	1543
query40	194	124	119	119
query41	40	37	36	36
query42	101	97	95	95
query43	582	564	547	547
query44	1198	719	751	719
query45	264	248	253	248
query46	1077	710	729	710
query47	1942	1869	1881	1869
query48	357	294	288	288
query49	867	381	387	381
query50	749	392	384	384
query51	6769	6636	6623	6623
query52	91	90	84	84
query53	347	286	283	283
query54	295	228	227	227
query55	77	72	75	72
query56	240	219	216	216
query57	1207	1112	1122	1112
query58	221	192	196	192
query59	3301	3180	3159	3159
query60	250	221	226	221
query61	89	87	84	84
query62	662	448	446	446
query63	301	289	282	282
query64	8591	7263	7189	7189
query65	3058	3043	3069	3043
query66	854	324	331	324
query67	15743	15047	14871	14871
query68	10476	552	537	537
query69	601	301	299	299
query70	1310	1062	1014	1014
query71	522	268	262	262
query72	8581	2574	2348	2348
query73	1579	312	320	312
query74	6615	6054	6112	6054
query75	5364	2644	2615	2615
query76	5965	990	1009	990
query77	716	263	265	263
query78	11068	10215	10094	10094
query79	11596	515	513	513
query80	2353	418	456	418
query81	488	221	224	221
query82	238	89	90	89
query83	214	163	160	160
query84	267	84	83	83
query85	1138	257	252	252
query86	336	317	303	303
query87	3302	3095	3090	3090
query88	5365	2311	2310	2310
query89	497	366	371	366
query90	2404	183	173	173
query91	125	97	96	96
query92	61	46	47	46
query93	7504	504	499	499
query94	1530	178	175	175
query95	385	295	292	292
query96	602	270	261	261
query97	3143	2980	2959	2959
query98	231	224	216	216
query99	1283	893	865	865
Total cold run time: 309646 ms
Total hot run time: 183858 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.67% (8965/25133)
Line Coverage: 27.28% (73965/271119)
Region Coverage: 26.47% (38210/144350)
Branch Coverage: 23.22% (19460/83814)
Coverage Report: http://coverage.selectdb-in.cc/coverage/886a278f12c11da72ce2941b5fa26dec8c6982b9_886a278f12c11da72ce2941b5fa26dec8c6982b9/report/index.html

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2024

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit ac23933 into apache:master May 5, 2024
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.x dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants