Skip to content

Conversation

@wangbo
Copy link
Contributor

@wangbo wangbo commented May 6, 2024

Proposed changes

Make workload group's stop scheduler a atomic operation to make code more readable.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wangbo
Copy link
Contributor Author

wangbo commented May 6, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40721 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2ec6f163f0b52740bc58b76c2f9ebe7199cf9cdb, data reload: false

------ Round 1 ----------------------------------
q1	17687	4544	4403	4403
q2	2593	205	221	205
q3	10920	1189	1178	1178
q4	10229	742	779	742
q5	7788	2681	2653	2653
q6	219	134	137	134
q7	1031	619	596	596
q8	9403	2111	2074	2074
q9	8875	6559	6505	6505
q10	9059	3715	3675	3675
q11	457	245	246	245
q12	540	228	223	223
q13	17771	3003	3021	3003
q14	268	220	215	215
q15	505	473	470	470
q16	515	381	372	372
q17	966	625	701	625
q18	8022	7345	7420	7345
q19	4291	1526	1519	1519
q20	650	319	319	319
q21	5104	3935	4127	3935
q22	357	285	290	285
Total cold run time: 117250 ms
Total hot run time: 40721 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4347	4250	4309	4250
q2	367	278	273	273
q3	2984	2785	2723	2723
q4	1860	1578	1654	1578
q5	5260	5296	5301	5296
q6	217	128	131	128
q7	2255	1875	1963	1875
q8	3192	3405	3379	3379
q9	8419	8403	8435	8403
q10	3890	3641	3691	3641
q11	585	490	484	484
q12	765	591	598	591
q13	16340	2985	3035	2985
q14	294	272	275	272
q15	525	481	487	481
q16	486	421	410	410
q17	1747	1482	1464	1464
q18	7862	7485	7423	7423
q19	1666	1561	1565	1561
q20	1950	1772	1784	1772
q21	5013	4878	4840	4840
q22	579	512	500	500
Total cold run time: 70603 ms
Total hot run time: 54329 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.61% (8965/25173)
Line Coverage: 27.25% (73981/271494)
Region Coverage: 26.47% (38221/144384)
Branch Coverage: 23.23% (19469/83796)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2ec6f163f0b52740bc58b76c2f9ebe7199cf9cdb_2ec6f163f0b52740bc58b76c2f9ebe7199cf9cdb/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 185259 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2ec6f163f0b52740bc58b76c2f9ebe7199cf9cdb, data reload: false

query1	928	357	345	345
query2	6466	2533	2395	2395
query3	6646	204	212	204
query4	23151	21136	21260	21136
query5	4126	427	428	427
query6	272	186	182	182
query7	4581	298	285	285
query8	258	180	181	180
query9	8667	2378	2364	2364
query10	438	247	251	247
query11	14767	14073	14065	14065
query12	144	90	88	88
query13	1646	367	374	367
query14	10636	7583	6754	6754
query15	271	165	172	165
query16	8143	259	256	256
query17	1855	555	533	533
query18	2102	286	271	271
query19	207	149	150	149
query20	94	86	83	83
query21	201	127	127	127
query22	4992	4831	4818	4818
query23	33858	33016	33087	33016
query24	10673	2857	2888	2857
query25	615	366	370	366
query26	1364	158	149	149
query27	3014	312	326	312
query28	7693	2054	2030	2030
query29	870	601	599	599
query30	275	152	152	152
query31	949	757	709	709
query32	94	52	57	52
query33	748	260	235	235
query34	1086	468	480	468
query35	788	669	664	664
query36	1084	864	879	864
query37	136	66	66	66
query38	3179	2979	2966	2966
query39	1603	1533	1528	1528
query40	206	133	128	128
query41	44	39	38	38
query42	109	96	96	96
query43	565	558	521	521
query44	1222	731	750	731
query45	271	257	249	249
query46	1068	720	725	720
query47	1956	1859	1854	1854
query48	387	296	300	296
query49	1081	402	438	402
query50	786	397	385	385
query51	6806	6727	6647	6647
query52	104	90	92	90
query53	352	285	293	285
query54	311	248	240	240
query55	79	71	72	71
query56	249	214	216	214
query57	1241	1125	1143	1125
query58	224	202	199	199
query59	3596	3346	3284	3284
query60	261	232	237	232
query61	94	90	90	90
query62	661	458	480	458
query63	312	280	287	280
query64	8719	7237	7214	7214
query65	3169	3081	3031	3031
query66	1411	342	334	334
query67	15428	15011	15010	15010
query68	6714	548	544	544
query69	528	310	310	310
query70	1192	1158	1173	1158
query71	456	269	270	269
query72	8137	2547	2385	2385
query73	733	322	320	320
query74	6565	6079	6157	6079
query75	3864	2652	2642	2642
query76	4213	1058	981	981
query77	668	266	323	266
query78	10843	10179	10144	10144
query79	5745	516	532	516
query80	1067	450	449	449
query81	520	220	227	220
query82	930	97	97	97
query83	205	173	172	172
query84	270	88	87	87
query85	1442	281	283	281
query86	464	306	299	299
query87	3201	3069	3036	3036
query88	5011	2328	2320	2320
query89	495	382	367	367
query90	1969	184	185	184
query91	125	106	131	106
query92	58	49	49	49
query93	5413	524	519	519
query94	1162	187	183	183
query95	404	305	310	305
query96	615	267	259	259
query97	3168	2969	2951	2951
query98	235	218	219	218
query99	1377	865	845	845
Total cold run time: 297121 ms
Total hot run time: 185259 ms

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit a3f0381 into apache:master May 6, 2024
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed workload-group

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants