Skip to content

[optimization](agg) add more type in agg percentile#34423

Merged
HappenLee merged 3 commits intoapache:masterfrom
Mryange:func-not-cast
May 8, 2024
Merged

[optimization](agg) add more type in agg percentile#34423
HappenLee merged 3 commits intoapache:masterfrom
Mryange:func-not-cast

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented May 6, 2024

Proposed changes

Add more supported types to reduce the cost of cast.

+-------+----------+------+-------+---------+-------+
| Field | Type     | Null | Key   | Default | Extra |
+-------+----------+------+-------+---------+-------+
| id    | INT      | Yes  | true  | NULL    |       |
| k1    | LARGEINT | Yes  | true  | NULL    |       |
| k2    | BIGINT   | Yes  | true  | NULL    |       |
| k3    | INT      | Yes  | false | NULL    | NONE  |
| k4    | SMALLINT | Yes  | false | NULL    | NONE  |
| k5    | TINYINT  | Yes  | false | NULL    | NONE  |
+-------+----------+------+-------+---------+-------+

before

output: partial_percentile(CAST(k1[#1] AS BIGINT), 0.5)[#6], partial_percentile(k2[#2], 0.5)[#7], partial_percentile(CAST(k3[#3] AS BIGINT), 0.5)[#8], partial_percentile(CAST(k4[#4] AS BIGINT), 0.5)[#9], partial_percentile(CAST(k5[#5] AS BIGINT), 0.5)[#10]  

mysql [ssb_sf100]>Select percentile(LO_SHIPPRIORITY,0.5) from lineorder_flat;
+------------------------------------------------------------------+
| percentile(cast(LO_SHIPPRIORITY as BIGINT), cast(0.5 as DOUBLE)) |
+------------------------------------------------------------------+
|                                                                0 |
+------------------------------------------------------------------+
1 row in set (12.41 sec)

now

output: partial_percentile(k1[#1], 0.5)[#6], partial_percentile(k2[#2], 0.5)[#7], partial_percentile(k3[#3], 0.5)[#8], partial_percentile(k4[#4], 0.5)[#9], partial_percentile(k5[#5], 0.5)


mysql [ssb_sf100]>Select percentile(LO_SHIPPRIORITY,0.5) from lineorder_flat;
+--------------------------------------------------+
| percentile(LO_SHIPPRIORITY, cast(0.5 as DOUBLE)) |
+--------------------------------------------------+
|                                                0 |
+--------------------------------------------------+
1 row in set (6.21 sec)

mysql [ssb_sf100]>Select percentile(cast(LO_SHIPPRIORITY as bigint),0.5) from lineorder_flat;
+------------------------------------------------------------------+
| percentile(cast(LO_SHIPPRIORITY as BIGINT), cast(0.5 as DOUBLE)) |
+------------------------------------------------------------------+
|                                                                0 |
+------------------------------------------------------------------+
1 row in set (12.41 sec)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented May 6, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Mryange
Copy link
Contributor Author

Mryange commented May 6, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 42000 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 337ec17ff7ea3ca4d18a23d377134c3b21165e79, data reload: false

------ Round 1 ----------------------------------
q1	17628	4231	4212	4212
q2	2033	190	188	188
q3	10499	1233	1161	1161
q4	10909	919	737	737
q5	7513	2715	2839	2715
q6	223	132	133	132
q7	1049	607	590	590
q8	9242	2179	2140	2140
q9	9539	6887	6855	6855
q10	9324	3872	3934	3872
q11	462	289	243	243
q12	480	228	228	228
q13	17546	3264	3342	3264
q14	279	226	221	221
q15	520	472	469	469
q16	533	425	406	406
q17	983	671	653	653
q18	8770	8518	8380	8380
q19	5997	1591	1534	1534
q20	698	334	329	329
q21	5264	4385	3393	3393
q22	355	281	278	278
Total cold run time: 119846 ms
Total hot run time: 42000 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4805	4383	4442	4383
q2	374	285	270	270
q3	3140	2976	2860	2860
q4	1958	1653	1781	1653
q5	5369	5362	5462	5362
q6	219	122	126	122
q7	2288	1971	1978	1971
q8	3255	3413	3441	3413
q9	8649	8715	8762	8715
q10	4068	3854	3718	3718
q11	581	476	472	472
q12	761	614	600	600
q13	15882	3155	3155	3155
q14	284	277	269	269
q15	527	488	481	481
q16	471	428	423	423
q17	1800	1484	1512	1484
q18	8126	7448	7308	7308
q19	2653	1541	1493	1493
q20	2014	1786	1778	1778
q21	12867	4795	4758	4758
q22	555	497	493	493
Total cold run time: 80646 ms
Total hot run time: 55181 ms

@Mryange
Copy link
Contributor Author

Mryange commented May 6, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40086 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 337ec17ff7ea3ca4d18a23d377134c3b21165e79, data reload: false

------ Round 1 ----------------------------------
q1	17753	4474	4367	4367
q2	2435	189	199	189
q3	11049	1198	1194	1194
q4	10368	720	769	720
q5	7968	2735	2643	2643
q6	220	135	136	135
q7	1023	616	605	605
q8	9522	2083	2066	2066
q9	9064	6607	6531	6531
q10	8956	3724	3677	3677
q11	465	237	232	232
q12	597	220	221	220
q13	17765	2970	2958	2958
q14	257	212	213	212
q15	512	471	481	471
q16	514	398	379	379
q17	969	716	790	716
q18	8042	7438	7333	7333
q19	3370	1529	1523	1523
q20	665	323	313	313
q21	5612	3322	3967	3322
q22	358	285	280	280
Total cold run time: 117484 ms
Total hot run time: 40086 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4311	4205	4195	4195
q2	367	275	263	263
q3	2981	2804	2771	2771
q4	1928	1583	1617	1583
q5	5272	5289	5292	5289
q6	209	125	127	125
q7	2289	1880	1911	1880
q8	3232	3370	3339	3339
q9	8514	8482	8474	8474
q10	3948	3680	3693	3680
q11	567	504	479	479
q12	773	600	588	588
q13	16292	2961	2950	2950
q14	284	281	257	257
q15	513	465	478	465
q16	466	419	425	419
q17	1761	1482	1455	1455
q18	7683	7443	7466	7443
q19	1898	1574	1583	1574
q20	1989	1735	1734	1734
q21	4968	4865	4929	4865
q22	562	487	499	487
Total cold run time: 70807 ms
Total hot run time: 54315 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187559 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 337ec17ff7ea3ca4d18a23d377134c3b21165e79, data reload: false

query1	912	364	350	350
query2	6836	2323	2336	2323
query3	6665	206	206	206
query4	22860	21368	21224	21224
query5	4150	429	439	429
query6	285	190	170	170
query7	4596	293	290	290
query8	262	201	188	188
query9	8478	2351	2337	2337
query10	427	245	271	245
query11	14712	14108	14126	14108
query12	133	88	95	88
query13	1629	396	365	365
query14	10441	7883	8263	7883
query15	250	172	175	172
query16	8192	261	257	257
query17	1838	594	541	541
query18	2112	284	264	264
query19	293	149	147	147
query20	93	90	84	84
query21	194	127	132	127
query22	5141	4896	4802	4802
query23	34057	33245	33261	33245
query24	10813	2862	2965	2862
query25	614	378	388	378
query26	1344	157	152	152
query27	2888	328	325	325
query28	7609	2032	2019	2019
query29	885	639	615	615
query30	288	163	157	157
query31	954	758	771	758
query32	99	51	55	51
query33	735	249	243	243
query34	1066	478	490	478
query35	806	662	676	662
query36	1050	946	938	938
query37	132	67	67	67
query38	3198	2997	3044	2997
query39	1562	1536	1537	1536
query40	194	129	125	125
query41	42	39	40	39
query42	103	97	95	95
query43	553	549	536	536
query44	1174	723	738	723
query45	269	249	251	249
query46	1083	714	730	714
query47	1965	1868	1892	1868
query48	379	301	300	300
query49	1075	397	420	397
query50	768	378	379	378
query51	6680	6586	6602	6586
query52	109	90	91	90
query53	355	282	280	280
query54	305	234	233	233
query55	78	73	72	72
query56	242	222	214	214
query57	1223	1120	1130	1120
query58	224	201	199	199
query59	3398	3176	3394	3176
query60	258	234	237	234
query61	89	85	87	85
query62	662	441	443	441
query63	306	279	281	279
query64	9768	7210	7296	7210
query65	3163	3052	3101	3052
query66	1083	334	336	334
query67	15227	14976	15161	14976
query68	5272	541	543	541
query69	482	306	296	296
query70	1189	1168	1110	1110
query71	384	272	264	264
query72	7843	2561	2331	2331
query73	696	330	330	330
query74	6534	6225	6117	6117
query75	3401	2617	2632	2617
query76	3059	1032	1018	1018
query77	483	267	270	267
query78	10778	10490	10360	10360
query79	7891	522	532	522
query80	1112	428	427	427
query81	517	229	219	219
query82	922	94	95	94
query83	224	164	165	164
query84	274	84	84	84
query85	1432	263	263	263
query86	460	293	307	293
query87	3328	3076	3079	3076
query88	5211	2337	2312	2312
query89	480	386	376	376
query90	2055	183	180	180
query91	128	95	96	95
query92	61	46	46	46
query93	6090	504	502	502
query94	1178	192	215	192
query95	1099	1090	1099	1090
query96	582	270	263	263
query97	3151	2947	2926	2926
query98	234	217	215	215
query99	1279	881	895	881
Total cold run time: 297203 ms
Total hot run time: 187559 ms

@Mryange
Copy link
Contributor Author

Mryange commented May 6, 2024

run buildall

@Mryange
Copy link
Contributor Author

Mryange commented May 6, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

HappenLee
HappenLee previously approved these changes May 6, 2024
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.61% (8966/25179)
Line Coverage: 27.28% (73979/271222)
Region Coverage: 26.49% (38204/144197)
Branch Coverage: 23.29% (19458/83536)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3ba57dca1c82be48d55f5097dbec035a28decc4a_3ba57dca1c82be48d55f5097dbec035a28decc4a/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 41981 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3ba57dca1c82be48d55f5097dbec035a28decc4a, data reload: false

------ Round 1 ----------------------------------
q1	17619	4240	4197	4197
q2	2007	190	184	184
q3	10471	1197	1262	1197
q4	10209	848	781	781
q5	7488	2712	2616	2616
q6	223	142	131	131
q7	1013	624	624	624
q8	9235	2160	2111	2111
q9	9508	6728	6735	6728
q10	9441	3911	3994	3911
q11	444	312	246	246
q12	439	235	225	225
q13	17523	3206	3222	3206
q14	254	217	217	217
q15	511	476	485	476
q16	497	414	396	396
q17	980	672	803	672
q18	8344	7955	7921	7921
q19	1668	1599	1530	1530
q20	644	319	315	315
q21	5368	4501	4015	4015
q22	361	299	282	282
Total cold run time: 114247 ms
Total hot run time: 41981 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4678	4439	4516	4439
q2	383	275	282	275
q3	3223	3018	2840	2840
q4	1912	1649	1618	1618
q5	5533	5549	5568	5549
q6	223	125	126	125
q7	2348	2144	2096	2096
q8	3317	3439	3427	3427
q9	8997	8979	8940	8940
q10	4154	3902	3925	3902
q11	584	508	496	496
q12	798	620	634	620
q13	15894	3198	3149	3149
q14	297	290	297	290
q15	536	481	493	481
q16	478	460	431	431
q17	1856	1552	1517	1517
q18	7935	7544	7512	7512
q19	1656	1552	1539	1539
q20	1972	1777	1762	1762
q21	11795	4890	4879	4879
q22	565	497	484	484
Total cold run time: 79134 ms
Total hot run time: 56371 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186068 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3ba57dca1c82be48d55f5097dbec035a28decc4a, data reload: false

query1	896	357	355	355
query2	6707	2428	2417	2417
query3	6632	200	209	200
query4	23050	21213	21110	21110
query5	4099	412	416	412
query6	267	174	172	172
query7	4594	293	297	293
query8	235	194	199	194
query9	8593	2379	2344	2344
query10	437	259	255	255
query11	14736	14141	14159	14141
query12	136	101	90	90
query13	1665	380	382	380
query14	9771	8386	7525	7525
query15	272	170	178	170
query16	8122	272	267	267
query17	1752	572	559	559
query18	2105	296	274	274
query19	329	159	161	159
query20	95	89	87	87
query21	195	131	123	123
query22	5012	4868	4817	4817
query23	33869	33254	33130	33130
query24	10687	2939	2960	2939
query25	587	387	384	384
query26	698	157	151	151
query27	2141	325	336	325
query28	5569	2050	2044	2044
query29	869	627	632	627
query30	254	158	154	154
query31	1012	744	729	729
query32	94	54	55	54
query33	656	258	255	255
query34	881	484	473	473
query35	823	663	665	663
query36	1092	879	916	879
query37	110	68	71	68
query38	3172	2962	2994	2962
query39	1597	1594	1541	1541
query40	203	133	135	133
query41	44	39	44	39
query42	103	108	98	98
query43	588	550	554	550
query44	1133	729	739	729
query45	271	257	257	257
query46	1077	720	723	720
query47	1965	1866	1828	1828
query48	379	307	309	307
query49	915	402	398	398
query50	784	382	396	382
query51	6748	6689	6613	6613
query52	108	93	95	93
query53	346	276	278	276
query54	313	245	245	245
query55	80	75	74	74
query56	239	225	226	225
query57	1210	1147	1132	1132
query58	219	202	206	202
query59	3392	3148	3131	3131
query60	267	235	244	235
query61	93	89	88	88
query62	620	460	449	449
query63	306	285	278	278
query64	8325	7290	7222	7222
query65	3099	3071	3073	3071
query66	782	329	358	329
query67	15850	15007	14852	14852
query68	9684	548	545	545
query69	603	311	300	300
query70	1395	1095	1129	1095
query71	469	271	271	271
query72	8537	2529	2340	2340
query73	1629	333	332	332
query74	6572	6133	6127	6127
query75	4256	2622	2663	2622
query76	5400	959	1031	959
query77	725	263	274	263
query78	10782	10515	10160	10160
query79	11383	523	519	519
query80	1904	424	430	424
query81	500	220	220	220
query82	169	98	95	95
query83	228	165	166	165
query84	266	87	82	82
query85	946	266	260	260
query86	348	279	309	279
query87	3344	3076	3116	3076
query88	5171	2336	2321	2321
query89	511	388	364	364
query90	2388	183	188	183
query91	129	100	100	100
query92	62	49	48	48
query93	6344	518	505	505
query94	1566	193	191	191
query95	415	300	306	300
query96	637	268	261	261
query97	3146	2970	2927	2927
query98	237	219	217	217
query99	1112	879	839	839
Total cold run time: 304128 ms
Total hot run time: 186068 ms

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Mryange
Copy link
Contributor Author

Mryange commented May 6, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40652 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a14c107938151c9d8c607eecd09031673412b98a, data reload: false

------ Round 1 ----------------------------------
q1	17666	4404	4342	4342
q2	2466	199	204	199
q3	11176	1146	1199	1146
q4	10646	721	794	721
q5	7604	2741	2677	2677
q6	220	135	132	132
q7	1033	589	568	568
q8	9235	2111	2085	2085
q9	9112	6584	6533	6533
q10	8966	3691	3696	3691
q11	452	244	237	237
q12	481	223	221	221
q13	17763	2946	2978	2946
q14	260	223	229	223
q15	504	477	467	467
q16	512	388	384	384
q17	958	657	674	657
q18	8100	7413	7373	7373
q19	1663	1519	1418	1418
q20	652	312	324	312
q21	5245	4066	4036	4036
q22	356	285	284	284
Total cold run time: 115070 ms
Total hot run time: 40652 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4295	4227	4223	4223
q2	384	279	272	272
q3	2992	2746	2742	2742
q4	1850	1636	1646	1636
q5	5264	5285	5290	5285
q6	214	125	126	125
q7	2244	1897	1866	1866
q8	3180	3344	3370	3344
q9	8413	8429	8424	8424
q10	3896	3681	3687	3681
q11	572	478	484	478
q12	754	602	577	577
q13	17391	2990	2972	2972
q14	303	271	243	243
q15	530	478	468	468
q16	464	416	414	414
q17	1743	1466	1450	1450
q18	7579	7623	7319	7319
q19	4174	1590	1594	1590
q20	2008	1756	1757	1756
q21	4992	5027	5050	5027
q22	576	489	475	475
Total cold run time: 73818 ms
Total hot run time: 54367 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.64% (8974/25183)
Line Coverage: 27.29% (74036/271264)
Region Coverage: 26.52% (38250/144222)
Branch Coverage: 23.32% (19481/83554)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a14c107938151c9d8c607eecd09031673412b98a_a14c107938151c9d8c607eecd09031673412b98a/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 186141 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a14c107938151c9d8c607eecd09031673412b98a, data reload: false

query1	897	358	347	347
query2	6466	2485	2460	2460
query3	6665	210	211	210
query4	23048	21374	21283	21283
query5	4176	417	434	417
query6	266	186	170	170
query7	4583	298	285	285
query8	255	198	198	198
query9	8365	2378	2364	2364
query10	435	244	263	244
query11	14687	14203	14188	14188
query12	133	93	90	90
query13	1645	370	364	364
query14	8738	7737	7283	7283
query15	243	164	174	164
query16	8099	263	269	263
query17	1842	558	545	545
query18	2068	284	266	266
query19	212	154	145	145
query20	96	88	95	88
query21	204	127	128	127
query22	5087	4823	4840	4823
query23	33858	33373	33031	33031
query24	11355	2906	2926	2906
query25	650	362	357	357
query26	1609	153	146	146
query27	3071	316	310	310
query28	7523	2033	2033	2033
query29	987	601	597	597
query30	286	149	151	149
query31	993	751	719	719
query32	90	51	52	51
query33	747	240	246	240
query34	1078	478	482	478
query35	774	681	659	659
query36	1033	933	928	928
query37	130	66	74	66
query38	3141	3029	2970	2970
query39	1605	1534	1572	1534
query40	281	124	128	124
query41	41	39	40	39
query42	105	101	97	97
query43	607	566	532	532
query44	1275	721	742	721
query45	266	255	256	255
query46	1083	696	704	696
query47	1968	1834	1877	1834
query48	376	290	289	289
query49	1122	411	401	401
query50	771	380	385	380
query51	6831	6628	6604	6604
query52	103	92	87	87
query53	349	280	274	274
query54	296	249	229	229
query55	78	73	73	73
query56	234	221	213	213
query57	1214	1140	1135	1135
query58	227	194	198	194
query59	3537	3199	3212	3199
query60	259	240	234	234
query61	93	87	101	87
query62	637	445	450	445
query63	305	278	279	278
query64	9603	7198	7162	7162
query65	3152	3086	3064	3064
query66	1096	360	337	337
query67	15292	15163	15180	15163
query68	5244	521	531	521
query69	483	317	313	313
query70	1132	1138	1153	1138
query71	417	277	268	268
query72	7705	2523	2339	2339
query73	703	314	314	314
query74	6555	6101	6171	6101
query75	3590	2629	2650	2629
query76	3425	1000	963	963
query77	410	271	265	265
query78	10818	10342	10253	10253
query79	8154	516	526	516
query80	1986	427	419	419
query81	544	227	225	225
query82	1630	95	96	95
query83	331	171	165	165
query84	271	84	81	81
query85	1601	268	272	268
query86	485	303	271	271
query87	3322	3060	3071	3060
query88	5184	2307	2304	2304
query89	500	372	385	372
query90	2035	180	179	179
query91	124	103	96	96
query92	61	47	47	47
query93	6312	509	489	489
query94	1233	180	176	176
query95	404	302	299	299
query96	590	269	261	261
query97	3147	2977	2994	2977
query98	243	218	217	217
query99	1252	876	876	876
Total cold run time: 298232 ms
Total hot run time: 186141 ms

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit ebf2b88 into apache:master May 8, 2024
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants