[Fix](Planner) add date/month/year add function fe constant fold with dateV2/dateTimeV2#34484
Merged
morrySnow merged 5 commits intoapache:branch-2.0from May 10, 2024
Merged
Conversation
… dateV2/dateTimeV2
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
morrySnow
requested changes
May 7, 2024
| @FEFunction(name = "months_add", argTypes = { "DATEV2", "INT" }, returnType = "DATEV2") | ||
| public static DateLiteral monthsAddDateV2(LiteralExpr date, LiteralExpr month) throws AnalysisException { | ||
| DateLiteral dateLiteral = (DateLiteral) date; | ||
| return dateLiteral.plusYears(month.getLongValue()); |
Contributor
There was a problem hiding this comment.
Suggested change
| return dateLiteral.plusYears(month.getLongValue()); | |
| return dateLiteral.plusMonths(month.getLongValue()); |
Contributor
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 49364 ms |
TPC-DS: Total hot run time: 202552 ms |
ClickBench: Total hot run time: 30.71 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
approved these changes
May 9, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run feut |
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
… dateV2/dateTimeV2 (apache#34484) cherry-pick: apache#34483 Problem and Cause: In original planner, date_add function would choose different data type of datetime or datev2. Which when original planner choose datev2 as constant date type. Fe could not folding date_add function because missing of function signature of folding constant date_add(datev2, int) Solved: Add corresponding function signatures of date_add/months_add/years_add in original planner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
cherry-pick: #34483
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...