[improvement](statistics)Remove collect external table row count task.#34487
Merged
morrySnow merged 1 commit intoapache:masterfrom May 8, 2024
Merged
[improvement](statistics)Remove collect external table row count task.#34487morrySnow merged 1 commit intoapache:masterfrom
morrySnow merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40140 ms |
TPC-DS: Total hot run time: 185191 ms |
Contributor
Author
|
run buildall |
Jibing-Li
force-pushed
the
externalrowcount
branch
2 times, most recently
from
8b7eca5 to
2de7018
Compare
Jibing-Li
force-pushed
the
externalrowcount
branch
from
2de7018 to
3b01346
Compare
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
morrySnow
approved these changes
May 8, 2024
ByteYue
pushed a commit
to ByteYue/doris
that referenced
this pull request
May 15, 2024
Before, we would create an analyze task for external table tocollect the row count of the table. But this is resource consuming and unnecessary. Because the planner doesn't use table row count, it fetch the row count from column row count. This pr is to remove this row count task for external table.
Jibing-Li
added
not-merge/2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we would create an analyze task for external table to collect the row count of the table. But this is resource consuming and unnecessary. Because the planner doesn't use table row count, it fetch the row count from column row count. This pr is to remove this row count task for external table.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...