[Fix](job)Reclaim resources held by finished tasks#34506
Merged
CalvinKirs merged 1 commit intoapache:masterfrom May 8, 2024
Merged
[Fix](job)Reclaim resources held by finished tasks#34506CalvinKirs merged 1 commit intoapache:masterfrom
CalvinKirs merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
CalvinKirs
force-pushed
the
master-wenqiang
branch
2 times, most recently
from
83d957a to
cdd1c84
Compare
closeOrReleaseResources(), which is responsible for safely closing or releasing the stmtExecutor, command, and ctx objects. The method follows a null check pattern to avoid NullPointerExceptions and ensures that resources are properly cleaned up when they are no longer needed. This improves code readability and maintains a consistent approach to resource management.
CalvinKirs
force-pushed
the
master-wenqiang
branch
from
cdd1c84 to
c281cdc
Compare
zddr
approved these changes
May 8, 2024
Contributor
|
PR approved by anyone and no changes requested. |
Member
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
May 10, 2024
closeOrReleaseResources(), which is responsible for safely closing or releasing the stmtExecutor, command, and ctx objects. The method follows a null check pattern to avoid NullPointerExceptions and ensures that resources are properly cleaned up when they are no longer needed. This improves code readability and maintains a consistent approach to resource management.
ByteYue
pushed a commit
to ByteYue/doris
that referenced
this pull request
May 15, 2024
closeOrReleaseResources(), which is responsible for safely closing or releasing the stmtExecutor, command, and ctx objects. The method follows a null check pattern to avoid NullPointerExceptions and ensures that resources are properly cleaned up when they are no longer needed. This improves code readability and maintains a consistent approach to resource management.
CalvinKirs
added
dev/2.0.3-merged
dev/2.1.3-merged
and removed
dev/2.0.3-merged
dev/2.1.x
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
What happened
Failure to explicitly release resources used by completed tasks can cause memory to remain in use until the task is cleared.
Affected versions
2.1.0 +
Changes
add closeOrReleaseResources method
make sure that resources are properly cleaned up when they are no longer needed. This improves code readability and maintains a consistent approach to resource management.
test
Testing on my test cluster