Skip to content

Conversation

@csun5285
Copy link
Contributor

@csun5285 csun5285 commented May 9, 2024

Proposed changes

Add metrics and test for single compaction

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@csun5285
Copy link
Contributor Author

csun5285 commented May 9, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@csun5285
Copy link
Contributor Author

csun5285 commented May 9, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.68% (8981/25171)
Line Coverage: 27.34% (74198/271434)
Region Coverage: 26.56% (38351/144371)
Branch Coverage: 23.39% (19564/83634)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7a621df8805477594c719cbbe80a77ca921b2fd7_7a621df8805477594c719cbbe80a77ca921b2fd7/report/index.html

@csun5285 csun5285 changed the title [chore](compaction)Add test for single compaction [chore](compaction)Add metrics and test for single compaction May 9, 2024
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 10, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@qidaye qidaye merged commit 0c59bef into apache:master May 10, 2024
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants