Skip to content

[fix](Nereids): fix choose id when there is enforcer in group #34573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackwener merged 1 commit into from
May 10, 2024
Merged

[fix](Nereids): fix choose id when there is enforcer in group #34573

jackwener merged 1 commit into from
May 10, 2024

Conversation

@keanji-x
Copy link
Contributor

@keanji-x keanji-x commented May 9, 2024 •
edited
Loading

Proposed changes

If the group has enforcer, the choose id should include the enforcer id

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented May 9, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@keanji-x
Copy link
Contributor Author

keanji-x commented May 9, 2024

run buildall

@keanji-x keanji-x changed the title [fix](Nereids): fix choose id when there is enforcer [fix](Nereids): fix choose id when there is enforcer in group May 9, 2024
@doris-robot
Copy link

doris-robot commented May 9, 2024

TPC-H: Total hot run time: 41283 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1be6e4a04e4b7d01ccfb0a8a73a8993a258deaf5, data reload: false

------ Round 1 ----------------------------------
q1	6318	4335	4291	4291
q2	656	184	189	184
q3	1436	1186	1123	1123
q4	1532	831	761	761
q5	2637	2712	2727	2712
q6	228	136	134	134
q7	988	534	511	511
q8	1999	2254	2280	2254
q9	7032	6939	6774	6774
q10	3905	3766	3755	3755
q11	368	255	248	248
q12	379	217	225	217
q13	16957	2972	2981	2972
q14	253	218	225	218
q15	526	474	487	474
q16	496	380	381	380
q17	970	735	777	735
q18	7929	7520	7471	7471
q19	1630	1546	1522	1522
q20	534	314	300	300
q21	5117	3969	4077	3969
q22	373	281	278	278
Total cold run time: 62263 ms
Total hot run time: 41283 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4276	4211	4254	4211
q2	369	280	277	277
q3	3018	2786	2778	2778
q4	1874	1610	1619	1610
q5	5300	5315	5303	5303
q6	207	122	125	122
q7	1791	1424	1406	1406
q8	3240	3404	3365	3365
q9	8401	8401	8436	8401
q10	3914	3671	3722	3671
q11	562	505	497	497
q12	754	592	596	592
q13	11178	2958	2995	2958
q14	296	258	256	256
q15	520	477	477	477
q16	460	430	432	430
q17	1796	1490	1485	1485
q18	7564	7650	7524	7524
q19	1664	1580	1587	1580
q20	1969	1764	1775	1764
q21	5143	4899	4859	4859
q22	591	495	501	495
Total cold run time: 64887 ms
Total hot run time: 54061 ms

@doris-robot
Copy link

doris-robot commented May 9, 2024

TPC-DS: Total hot run time: 187657 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1be6e4a04e4b7d01ccfb0a8a73a8993a258deaf5, data reload: false

query1	865	368	349	349
query2	6457	2346	2393	2346
query3	6657	207	216	207
query4	24495	21271	21164	21164
query5	4160	414	416	414
query6	275	184	192	184
query7	4591	295	294	294
query8	241	185	184	184
query9	8524	2424	2396	2396
query10	455	257	254	254
query11	14747	14184	14227	14184
query12	152	98	91	91
query13	1649	384	384	384
query14	8955	7887	7651	7651
query15	253	170	181	170
query16	8162	272	273	272
query17	1840	569	558	558
query18	2114	283	276	276
query19	218	152	154	152
query20	94	90	87	87
query21	198	134	129	129
query22	5088	4890	4851	4851
query23	34336	33775	33597	33597
query24	10463	2938	2836	2836
query25	592	381	380	380
query26	702	158	155	155
query27	2165	329	346	329
query28	5963	2062	2045	2045
query29	880	636	626	626
query30	287	156	154	154
query31	987	761	738	738
query32	95	56	55	55
query33	660	263	257	257
query34	895	492	493	492
query35	805	680	679	679
query36	1084	897	922	897
query37	102	73	69	69
query38	2932	2751	2747	2747
query39	1617	1549	1562	1549
query40	209	133	127	127
query41	46	41	40	40
query42	105	96	104	96
query43	607	575	554	554
query44	1076	731	746	731
query45	279	252	253	252
query46	1073	696	729	696
query47	1942	1875	1866	1866
query48	377	301	304	301
query49	1043	396	415	396
query50	772	389	399	389
query51	6892	6811	6723	6723
query52	102	94	91	91
query53	351	283	280	280
query54	945	431	437	431
query55	73	75	72	72
query56	238	221	227	221
query57	1206	1156	1141	1141
query58	219	209	201	201
query59	3682	3228	3188	3188
query60	256	239	239	239
query61	93	89	88	88
query62	647	462	479	462
query63	317	284	287	284
query64	8472	7415	7376	7376
query65	3154	3070	3111	3070
query66	816	338	332	332
query67	15727	14969	15214	14969
query68	9003	545	546	545
query69	612	324	316	316
query70	1405	1151	1129	1129
query71	513	269	273	269
query72	8615	2544	2368	2368
query73	1612	325	330	325
query74	6674	6122	6117	6117
query75	4837	2635	2687	2635
query76	5333	1002	996	996
query77	656	265	270	265
query78	11060	10300	10297	10297
query79	6349	515	506	506
query80	1013	440	440	440
query81	496	218	224	218
query82	241	96	91	91
query83	195	173	168	168
query84	264	89	88	88
query85	838	269	266	266
query86	341	298	294	294
query87	3287	3133	3050	3050
query88	4612	2426	2442	2426
query89	486	371	380	371
query90	2055	195	194	194
query91	128	96	97	96
query92	62	59	52	52
query93	4988	528	508	508
query94	1262	184	185	184
query95	397	313	321	313
query96	604	267	267	267
query97	3216	2943	2953	2943
query98	240	222	209	209
query99	1229	920	893	893
Total cold run time: 298097 ms
Total hot run time: 187657 ms

@keanji-x
Copy link
Contributor Author

keanji-x commented May 9, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented May 9, 2024

TPC-H: Total hot run time: 39837 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1be6e4a04e4b7d01ccfb0a8a73a8993a258deaf5, data reload: false

------ Round 1 ----------------------------------
q1	17604	4468	4250	4250
q2	2019	196	195	195
q3	10492	1177	1249	1177
q4	10149	778	756	756
q5	7468	2669	2661	2661
q6	213	130	132	130
q7	948	533	519	519
q8	9234	2136	2069	2069
q9	8755	6560	6466	6466
q10	8919	3741	3717	3717
q11	452	243	238	238
q12	448	223	220	220
q13	17778	2949	2925	2925
q14	255	217	221	217
q15	514	468	478	468
q16	507	376	380	376
q17	958	714	725	714
q18	8066	7513	7449	7449
q19	7179	1526	1500	1500
q20	652	303	322	303
q21	4968	3210	4005	3210
q22	375	278	277	277
Total cold run time: 117953 ms
Total hot run time: 39837 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4299	4222	4215	4215
q2	381	266	269	266
q3	3015	2726	2767	2726
q4	1835	1528	1592	1528
q5	5270	5253	5270	5253
q6	212	124	122	122
q7	1794	1391	1421	1391
q8	3188	3311	3310	3310
q9	8320	8312	8327	8312
q10	3869	3693	3653	3653
q11	590	484	504	484
q12	759	619	569	569
q13	17356	2929	2968	2929
q14	301	258	254	254
q15	523	478	476	476
q16	460	421	411	411
q17	1765	1469	1474	1469
q18	7589	7581	7460	7460
q19	1646	1577	1598	1577
q20	1961	1781	1787	1781
q21	4966	4908	4857	4857
q22	572	496	496	496
Total cold run time: 70671 ms
Total hot run time: 53539 ms

@doris-robot
Copy link

doris-robot commented May 9, 2024

TPC-DS: Total hot run time: 188241 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1be6e4a04e4b7d01ccfb0a8a73a8993a258deaf5, data reload: false

query1	907	365	341	341
query2	6454	2481	2383	2383
query3	6650	211	208	208
query4	22957	21165	21272	21165
query5	4224	421	407	407
query6	274	183	186	183
query7	4592	292	291	291
query8	254	207	181	181
query9	8683	2411	2382	2382
query10	446	246	244	244
query11	14671	14245	14126	14126
query12	128	91	85	85
query13	1631	360	371	360
query14	9637	8452	8372	8372
query15	264	163	180	163
query16	8167	270	261	261
query17	1843	549	555	549
query18	2116	284	279	279
query19	241	153	154	153
query20	97	91	87	87
query21	202	135	128	128
query22	5060	4902	4849	4849
query23	34500	33644	33720	33644
query24	11103	2937	2867	2867
query25	639	381	384	381
query26	1562	163	160	160
query27	2971	324	340	324
query28	7352	2065	2054	2054
query29	969	652	636	636
query30	288	156	154	154
query31	974	762	735	735
query32	99	56	56	56
query33	759	253	254	253
query34	1023	498	487	487
query35	816	677	677	677
query36	1107	942	918	918
query37	144	67	69	67
query38	2934	2764	2798	2764
query39	1631	1572	1567	1567
query40	272	129	126	126
query41	47	41	41	41
query42	110	97	101	97
query43	595	557	569	557
query44	1258	727	728	727
query45	269	250	257	250
query46	1073	717	734	717
query47	1955	1885	1889	1885
query48	368	293	307	293
query49	1205	400	407	400
query50	784	406	390	390
query51	6957	6821	6906	6821
query52	103	92	94	92
query53	354	291	280	280
query54	936	440	449	440
query55	77	78	81	78
query56	253	229	229	229
query57	1243	1148	1139	1139
query58	232	206	215	206
query59	3411	3358	3194	3194
query60	271	334	237	237
query61	88	86	90	86
query62	657	477	464	464
query63	314	287	282	282
query64	9783	7384	7360	7360
query65	3151	3094	3056	3056
query66	1401	349	349	349
query67	15736	14838	14924	14838
query68	9488	552	557	552
query69	595	318	310	310
query70	1406	1150	1052	1052
query71	498	273	259	259
query72	8886	2510	2366	2366
query73	1564	324	327	324
query74	6571	6157	6102	6102
query75	5006	2603	2628	2603
query76	5163	1016	939	939
query77	635	268	263	263
query78	10896	10500	10253	10253
query79	6806	512	517	512
query80	999	429	428	428
query81	490	214	260	214
query82	237	92	92	92
query83	192	164	166	164
query84	268	84	90	84
query85	931	267	267	267
query86	347	323	321	321
query87	3350	3174	3105	3105
query88	4648	2421	2423	2421
query89	495	377	393	377
query90	1999	189	194	189
query91	127	98	98	98
query92	56	50	77	50
query93	5200	517	507	507
query94	1263	181	184	181
query95	400	307	312	307
query96	607	267	262	262
query97	3163	2957	2965	2957
query98	238	221	217	217
query99	1103	924	890	890
Total cold run time: 304899 ms
Total hot run time: 188241 ms

@jackwener jackwener merged commit 9da0233 into apache:master May 10, 2024
yiguolei pushed a commit that referenced this pull request May 11, 2024
@keanji-x @Doris-Extras
[fix](Nereids): fix choose id when there is enforcer in group (#34573)
1dcf8a4
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
@keanji-x @ByteYue
[fix](Nereids): fix choose id when there is enforcer in group (apache…
550031d 
…#34573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackwener jackwener jackwener approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.3-merged dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@keanji-x @doris-robot @jackwener @morrySnow @dataroaring