Skip to content

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented May 9, 2024

Proposed changes

Issue Number: close #xxx

How to reproduce:

1、

MySQL [test]> admin set frontend config ("label_num_threshold" = "5");
Query OK, 0 rows affected (0.00 sec)

2、And insert 6 times into a table.

3、check the number of completed transactions.

MySQL [test]> show proc '/transactions/{db_id}';
+----------+--------+
| State    | Number |
+----------+--------+
| running  | 0      |
| finished | 6      |
+----------+--------+
2 rows in set (0.01 sec)

You can see that even if the history of completed transactions exceeds the threshold, they have not been cleared yet.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xy720
Copy link
Member Author

xy720 commented May 9, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39831 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7f4c3d414c46f3f131ad2ff942b8c46d77614eb8, data reload: false

------ Round 1 ----------------------------------
q1	17651	4455	4321	4321
q2	2966	189	200	189
q3	10826	1163	1196	1163
q4	10529	812	847	812
q5	7480	2671	2697	2671
q6	217	133	135	133
q7	1007	577	557	557
q8	9218	2094	2049	2049
q9	9083	6571	6527	6527
q10	8914	3764	3752	3752
q11	439	245	235	235
q12	387	219	216	216
q13	18813	2914	2959	2914
q14	258	221	224	221
q15	506	463	480	463
q16	485	376	372	372
q17	951	651	759	651
q18	7952	7331	7367	7331
q19	1917	1539	1504	1504
q20	636	316	303	303
q21	5017	3168	3273	3168
q22	342	285	279	279
Total cold run time: 115594 ms
Total hot run time: 39831 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4275	4178	4170	4170
q2	385	275	264	264
q3	2981	2756	2768	2756
q4	1847	1566	1559	1559
q5	5268	5272	5266	5266
q6	212	124	123	123
q7	2197	1896	1861	1861
q8	3186	3346	3342	3342
q9	8331	8268	8357	8268
q10	3904	3700	3692	3692
q11	566	496	470	470
q12	747	593	569	569
q13	16554	2941	2958	2941
q14	275	261	271	261
q15	531	467	475	467
q16	473	407	419	407
q17	1782	1498	1477	1477
q18	7699	7548	7404	7404
q19	1648	1563	1546	1546
q20	1971	1808	1758	1758
q21	9999	4879	4804	4804
q22	563	512	498	498
Total cold run time: 75394 ms
Total hot run time: 53903 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187126 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7f4c3d414c46f3f131ad2ff942b8c46d77614eb8, data reload: false

query1	917	359	352	352
query2	6444	2505	2271	2271
query3	6671	205	210	205
query4	23175	21370	21203	21203
query5	4142	428	429	428
query6	274	186	184	184
query7	4586	302	292	292
query8	248	189	198	189
query9	8398	2422	2399	2399
query10	431	253	244	244
query11	14738	14378	14108	14108
query12	133	89	87	87
query13	1641	381	377	377
query14	8927	8737	6921	6921
query15	246	165	171	165
query16	8128	269	270	269
query17	1840	555	549	549
query18	2100	295	277	277
query19	290	154	149	149
query20	100	83	86	83
query21	197	122	124	122
query22	4971	4877	4829	4829
query23	34416	33716	33756	33716
query24	10778	2868	2845	2845
query25	619	371	356	356
query26	1362	160	152	152
query27	3013	318	347	318
query28	7735	2037	2054	2037
query29	882	620	592	592
query30	301	152	161	152
query31	965	744	732	732
query32	89	53	55	53
query33	755	255	253	253
query34	1054	501	496	496
query35	829	689	676	676
query36	1089	884	943	884
query37	131	71	67	67
query38	2915	2788	2755	2755
query39	1599	1595	1570	1570
query40	198	128	129	128
query41	48	59	40	40
query42	106	99	98	98
query43	547	526	527	526
query44	1248	720	725	720
query45	268	261	252	252
query46	1083	716	719	716
query47	1945	1857	1887	1857
query48	375	301	293	293
query49	1099	405	396	396
query50	774	398	390	390
query51	6888	6813	6868	6813
query52	102	88	90	88
query53	352	288	288	288
query54	888	438	445	438
query55	74	78	77	77
query56	254	251	239	239
query57	1231	1190	1135	1135
query58	240	229	214	214
query59	3535	3079	3109	3079
query60	277	244	246	244
query61	111	109	110	109
query62	688	473	479	473
query63	311	296	285	285
query64	8931	7470	7430	7430
query65	3228	3131	3111	3111
query66	1422	355	366	355
query67	15409	14969	15434	14969
query68	4660	545	535	535
query69	489	310	320	310
query70	1178	1165	1148	1148
query71	413	279	282	279
query72	8036	2719	2611	2611
query73	693	329	332	329
query74	6538	6133	6154	6133
query75	3444	2673	2625	2625
query76	2784	1012	1056	1012
query77	448	266	266	266
query78	11080	10223	10081	10081
query79	7639	517	529	517
query80	1324	449	437	437
query81	508	230	221	221
query82	798	98	97	97
query83	202	168	172	168
query84	272	89	87	87
query85	1466	270	283	270
query86	408	321	298	298
query87	3328	3134	3123	3123
query88	5192	2404	2419	2404
query89	512	389	391	389
query90	2067	193	194	193
query91	126	97	99	97
query92	62	50	48	48
query93	5503	520	499	499
query94	1129	186	188	186
query95	400	308	313	308
query96	622	274	263	263
query97	3166	2950	2961	2950
query98	244	227	209	209
query99	1323	913	924	913
Total cold run time: 294815 ms
Total hot run time: 187126 ms

Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.x dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants