Skip to content

Conversation

@kaka11chen
Copy link
Contributor

Proposed changes

[Fix] (regression-test) Fix test_hive_write_type regression test.
Because #34397 changed error code of ARITHMETIC_OVERFLOW_ERRROR, so the error msg is not expected in the test.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaka11chen
Copy link
Contributor Author

run buildall

@kaka11chen kaka11chen force-pushed the fix_hive_write_type_test branch from e8a311f to e518abe Compare May 10, 2024 15:43
@kaka11chen
Copy link
Contributor Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 13, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 5e45937 into apache:master May 15, 2024
yiguolei pushed a commit that referenced this pull request May 15, 2024
Because #34397 changed error code of ARITHMETIC_OVERFLOW_ERRROR, so the error msg is not expected in the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.3-merged dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants