[pick](Nereids)revert modificiation on clucene (#34275)#34696
Merged
englefly merged 1 commit intoapache:branch-2.1from May 11, 2024
Merged
[pick](Nereids)revert modificiation on clucene (#34275)#34696englefly merged 1 commit intoapache:branch-2.1from
englefly merged 1 commit intoapache:branch-2.1from
Conversation
1. unify the process of generating rf for hash join and for nested loop join 2. fix some bugs in generating rf 3. remove some duplicated check (cherry picked from commit 07267fa) Revert "[pick](nereids)Runtime filter pushdown refactor for branch-2.1 (apache#34682)" [refactor](nereids) do not deny a runtime filter by removing an entry in aliasMap (apache#34559) in current version, there are 2 approaches to verify whether a join condition can be used to generate a runtime filter, they are 1. remove the output slot from aliasMap 2. pushDownVisitor.visit(...) return false the 1st approach has some drawbacks, we prefer to the 2ed approach. In this pr, all the cases are handled by the 2ed approach, and remove the related code for the 1st approach. (cherry picked from commit a29082b)
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
englefly
changed the title
englefly
changed the title
Contributor
Author
|
this pr revert the modification on clucene introduced by pr #34682 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
this pr revert the modification on clucene introduced by pr #34682
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...