Skip to content

Conversation

@w41ter
Copy link
Contributor

@w41ter w41ter commented May 11, 2024

Proposed changes

Issue Number: ref #33303

The LocalFileWriter will remove the file if it was not closed during destruction, so the BrokerFileSystem::download_impl downloads the target file and removes it later.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@w41ter
Copy link
Contributor Author

w41ter commented May 11, 2024

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 11, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 40531 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a27b7cafa2ec71eb89a8ee06e4a1aaa8dd3fd7c9, data reload: false

------ Round 1 ----------------------------------
q1	17610	4328	4280	4280
q2	2017	191	191	191
q3	10583	1292	1169	1169
q4	11563	790	756	756
q5	7558	2685	2652	2652
q6	225	132	139	132
q7	943	543	546	543
q8	9280	2116	2072	2072
q9	9481	6680	6647	6647
q10	9029	3727	3681	3681
q11	459	241	244	241
q12	484	216	213	213
q13	17761	2973	2925	2925
q14	254	220	213	213
q15	512	461	464	461
q16	504	393	380	380
q17	949	584	745	584
q18	8020	7429	7362	7362
q19	6513	1507	1512	1507
q20	650	311	307	307
q21	5096	3935	4099	3935
q22	357	280	287	280
Total cold run time: 119848 ms
Total hot run time: 40531 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4352	4324	4219	4219
q2	380	276	260	260
q3	2952	2743	2716	2716
q4	1872	1578	1569	1569
q5	5260	5274	5252	5252
q6	209	124	125	124
q7	1713	1382	1409	1382
q8	3167	3348	3323	3323
q9	8334	8405	8340	8340
q10	3836	3614	3652	3614
q11	582	500	504	500
q12	754	556	591	556
q13	17108	2917	2984	2917
q14	289	285	259	259
q15	515	481	470	470
q16	461	409	419	409
q17	1769	1478	1466	1466
q18	7444	7504	7295	7295
q19	1675	1536	1552	1536
q20	1977	1772	1776	1772
q21	5097	5009	5178	5009
q22	564	503	490	490
Total cold run time: 70310 ms
Total hot run time: 53478 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.65% (8981/25190)
Line Coverage: 27.33% (74256/271733)
Region Coverage: 26.57% (38388/144502)
Branch Coverage: 23.39% (19578/83716)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a27b7cafa2ec71eb89a8ee06e4a1aaa8dd3fd7c9_a27b7cafa2ec71eb89a8ee06e4a1aaa8dd3fd7c9/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 186959 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a27b7cafa2ec71eb89a8ee06e4a1aaa8dd3fd7c9, data reload: false

query1	902	369	345	345
query2	6963	2347	2284	2284
query3	6652	217	217	217
query4	22972	21236	21069	21069
query5	4248	419	410	410
query6	262	171	179	171
query7	4577	285	282	282
query8	239	189	186	186
query9	8483	2420	2460	2420
query10	436	260	257	257
query11	14990	14258	14158	14158
query12	134	96	88	88
query13	1646	373	374	373
query14	8898	7825	8444	7825
query15	261	168	169	168
query16	8184	266	261	261
query17	1857	543	552	543
query18	2099	275	263	263
query19	321	148	146	146
query20	95	81	84	81
query21	192	122	125	122
query22	5047	4856	4817	4817
query23	34421	33453	33654	33453
query24	10721	3048	3009	3009
query25	605	364	357	357
query26	1527	153	152	152
query27	2898	316	333	316
query28	7555	2052	2049	2049
query29	934	606	600	600
query30	297	152	150	150
query31	975	760	746	746
query32	96	55	51	51
query33	742	247	239	239
query34	1043	472	473	472
query35	806	689	681	681
query36	1088	930	890	890
query37	138	66	66	66
query38	2890	2771	2788	2771
query39	1632	1558	1535	1535
query40	269	121	121	121
query41	41	39	37	37
query42	103	93	97	93
query43	606	566	563	563
query44	1212	721	723	721
query45	270	250	254	250
query46	1093	710	711	710
query47	1979	1896	1843	1843
query48	379	306	294	294
query49	1152	388	402	388
query50	780	380	389	380
query51	6886	6771	6876	6771
query52	109	88	87	87
query53	354	285	284	284
query54	908	427	425	425
query55	75	74	77	74
query56	245	212	215	212
query57	1272	1136	1150	1136
query58	217	195	222	195
query59	3494	3309	3053	3053
query60	274	233	228	228
query61	90	85	85	85
query62	707	472	469	469
query63	303	284	283	283
query64	9790	7376	7429	7376
query65	3151	3104	3052	3052
query66	1387	347	342	342
query67	15451	15072	14836	14836
query68	4599	529	529	529
query69	481	298	301	298
query70	1146	1124	1195	1124
query71	407	267	265	265
query72	7929	2564	2333	2333
query73	700	320	322	320
query74	6582	6210	6086	6086
query75	3499	2636	2654	2636
query76	2920	989	1007	989
query77	443	260	263	260
query78	10520	10252	10091	10091
query79	2434	513	513	513
query80	1026	433	441	433
query81	517	227	229	227
query82	950	94	94	94
query83	246	166	170	166
query84	238	88	90	88
query85	1316	322	318	318
query86	438	329	318	318
query87	3316	3076	3079	3076
query88	4112	2415	2412	2412
query89	474	386	383	383
query90	2023	186	195	186
query91	134	108	108	108
query92	56	50	51	50
query93	1748	510	500	500
query94	1276	186	191	186
query95	395	303	308	303
query96	590	265	265	265
query97	3202	2989	2962	2962
query98	228	221	218	218
query99	1130	934	891	891
Total cold run time: 285498 ms
Total hot run time: 186959 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.11-merged dev/3.0.0-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants