-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](fs) Close local file writer when downloading via broker fs #34714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](fs) Close local file writer when downloading via broker fs #34714
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40531 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 186959 ms |
Proposed changes
Issue Number: ref #33303
The LocalFileWriter will remove the file if it was not closed during destruction, so the BrokerFileSystem::download_impl downloads the target file and removes it later.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...