[Fix](auto-partition) fix auto partition load lost data in multi sender #34740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40797 ms |
TPC-DS: Total hot run time: 186958 ms |
HappenLee
reviewed
May 13, 2024
HappenLee
reviewed
May 13, 2024
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41730 ms |
TPC-DS: Total hot run time: 187323 ms |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
zclllyybb
commented
May 15, 2024
zclllyybb
commented
May 15, 2024
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
liaoxin01
reviewed
May 15, 2024
| } | ||
| }; | ||
|
|
||
| struct WriteBlockCallbackContext { |
Contributor
There was a problem hiding this comment.
Only one variable, no need this structure？
Contributor
Author
There was a problem hiding this comment.
introduced in progress of this pr. for more change possible in the future I think this is more friendly so didn't remove this.
TPC-H: Total hot run time: 41113 ms |
TPC-DS: Total hot run time: 187038 ms |
Contributor
Author
|
run buildall |
ClickBench: Total hot run time: 30.37 s |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
Contributor
Author
|
close this since #35287 covered |
liaoxin01
pushed a commit
that referenced
this pull request
May 29, 2024
…er (#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace #34740 Co-authored-by: zhaochangle <zhaochangle@selectdb.com>
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
May 30, 2024
…er (apache#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace apache#34740 Co-authored-by: zhaochangle <zhaochangle@selectdb.com>
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
May 30, 2024
…er (apache#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace apache#34740 Co-authored-by: zhaochangle <zhaochangle@selectdb.com>
dataroaring
pushed a commit
that referenced
this pull request
May 31, 2024
…er (#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace #34740 Co-authored-by: zhaochangle <zhaochangle@selectdb.com>
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Jun 19, 2024
…er (apache#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace apache#34740 Co-authored-by: zhaochangle <zhaochangle@selectdb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Before if we have multi sender but some of their sink node have no data of some specific partition, then this sink won't know it has to close it. So tablets channel won't be closed correctly.
Now change close time needed count to same with open in tablets channel.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...