[improve](function) add limit check for lpad/rpad function input big value of length#34810
Merged
HappenLee merged 4 commits intoapache:masterfrom May 20, 2024
Merged
[improve](function) add limit check for lpad/rpad function input big value of length#34810HappenLee merged 4 commits intoapache:masterfrom
HappenLee merged 4 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40312 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 186804 ms |
TPC-H: Total hot run time: 40653 ms |
TPC-DS: Total hot run time: 186868 ms |
zclllyybb
reviewed
May 14, 2024
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41791 ms |
TPC-DS: Total hot run time: 187415 ms |
ClickBench: Total hot run time: 30.61 s |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40591 ms |
TPC-DS: Total hot run time: 187618 ms |
ClickBench: Total hot run time: 30.57 s |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41584 ms |
TPC-DS: Total hot run time: 186604 ms |
ClickBench: Total hot run time: 30.05 s |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41738 ms |
TPC-DS: Total hot run time: 187109 ms |
ClickBench: Total hot run time: 31.05 s |
Contributor
Author
|
run performance |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
jacktengg
approved these changes
May 20, 2024
dataroaring
pushed a commit
that referenced
this pull request
May 26, 2024
…value of length (#34810)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the user input big value of length, maybe cause some memory problem or
exceeded size limit of thrift, so add this check to report error for user firstly.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...