Skip to content

[Fix](temporary) temporarily forbid fold constant by BE for GeoFunctions#34857

Merged
HappenLee merged 1 commit intoapache:masterfrom
zclllyybb:forbid_st
May 15, 2024
Merged

[Fix](temporary) temporarily forbid fold constant by BE for GeoFunctions#34857
HappenLee merged 1 commit intoapache:masterfrom
zclllyybb:forbid_st

Conversation

@zclllyybb
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

now fold constant on BE may get wrong result for geofunctions. so we temporarily forbid it. Will release after we support real Geo types.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41613 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6077df4d7b002d9a6b0cf2ae88979fffec19b2d0, data reload: false

------ Round 1 ----------------------------------
q1	6253	4373	4272	4272
q2	1652	192	199	192
q3	1490	1191	1238	1191
q4	3171	800	774	774
q5	4891	2716	2667	2667
q6	258	157	159	157
q7	1205	651	618	618
q8	2311	2161	2136	2136
q9	6902	6775	6754	6754
q10	9095	4006	3961	3961
q11	473	253	250	250
q12	397	222	231	222
q13	16468	3196	3190	3190
q14	277	234	246	234
q15	522	484	486	484
q16	535	382	372	372
q17	978	711	740	711
q18	8190	7940	7869	7869
q19	1609	1611	1532	1532
q20	667	316	321	316
q21	5335	3426	4109	3426
q22	368	289	285	285
Total cold run time: 73047 ms
Total hot run time: 41613 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4401	4214	4343	4214
q2	383	264	258	258
q3	3097	2867	2899	2867
q4	1999	1685	1669	1669
q5	5617	5424	5266	5266
q6	211	124	124	124
q7	2246	1915	1890	1890
q8	3223	3362	3352	3352
q9	8357	8324	8367	8324
q10	3906	3707	3688	3688
q11	563	482	510	482
q12	764	618	617	617
q13	16461	3003	2968	2968
q14	283	273	253	253
q15	513	466	482	466
q16	460	405	429	405
q17	1777	1481	1491	1481
q18	7750	7593	7351	7351
q19	2039	1553	1552	1552
q20	1976	1755	1709	1709
q21	5897	4926	4978	4926
q22	590	489	475	475
Total cold run time: 72513 ms
Total hot run time: 54337 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187284 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6077df4d7b002d9a6b0cf2ae88979fffec19b2d0, data reload: false

query1	898	398	371	371
query2	6443	2418	2266	2266
query3	6648	206	207	206
query4	26211	21316	21141	21141
query5	4156	427	426	426
query6	261	174	171	171
query7	4580	295	285	285
query8	254	197	199	197
query9	8512	2490	2484	2484
query10	441	257	263	257
query11	14662	14313	14200	14200
query12	133	93	88	88
query13	1648	389	378	378
query14	10059	8511	7647	7647
query15	273	171	177	171
query16	8131	261	254	254
query17	1759	559	539	539
query18	2093	275	272	272
query19	199	147	148	147
query20	90	91	87	87
query21	200	131	136	131
query22	5085	4833	4790	4790
query23	34096	33563	33580	33563
query24	7578	2975	2854	2854
query25	565	370	366	366
query26	710	159	149	149
query27	2161	324	346	324
query28	5016	2077	2074	2074
query29	855	616	607	607
query30	260	175	181	175
query31	951	774	730	730
query32	92	53	57	53
query33	500	252	248	248
query34	878	478	484	478
query35	751	657	648	648
query36	1022	917	892	892
query37	110	73	68	68
query38	2901	2760	2765	2760
query39	1593	1557	1566	1557
query40	201	121	150	121
query41	46	43	42	42
query42	103	93	96	93
query43	561	559	525	525
query44	1089	722	737	722
query45	266	250	259	250
query46	1075	718	735	718
query47	1991	1880	1890	1880
query48	389	309	308	308
query49	866	403	398	398
query50	775	387	389	387
query51	6701	6744	6716	6716
query52	106	90	93	90
query53	344	285	293	285
query54	538	426	438	426
query55	77	72	70	70
query56	238	214	220	214
query57	1208	1155	1163	1155
query58	218	198	213	198
query59	3342	3248	3115	3115
query60	275	247	244	244
query61	91	91	86	86
query62	648	482	467	467
query63	309	280	283	280
query64	8502	7392	7428	7392
query65	3112	3092	3085	3085
query66	785	339	338	338
query67	15408	14851	14959	14851
query68	4494	538	533	533
query69	468	302	304	302
query70	1172	1123	1144	1123
query71	373	268	268	268
query72	7742	2571	2377	2377
query73	711	336	336	336
query74	6551	6118	6098	6098
query75	3323	2631	2619	2619
query76	2320	1001	989	989
query77	392	264	264	264
query78	10555	10288	10167	10167
query79	1684	529	531	529
query80	1134	444	429	429
query81	552	249	241	241
query82	947	96	97	96
query83	243	162	163	162
query84	246	92	89	89
query85	1137	272	260	260
query86	376	298	303	298
query87	3299	3197	3098	3098
query88	3204	2451	2446	2446
query89	468	401	384	384
query90	1981	185	187	185
query91	132	96	99	96
query92	58	47	47	47
query93	1645	515	496	496
query94	1152	181	192	181
query95	398	310	311	310
query96	584	271	274	271
query97	3108	2967	2981	2967
query98	233	224	217	217
query99	1211	934	896	896
Total cold run time: 273932 ms
Total hot run time: 187284 ms

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 14, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

ClickBench: Total hot run time: 30.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6077df4d7b002d9a6b0cf2ae88979fffec19b2d0, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.04	0.04
query3	0.23	0.04	0.05
query4	1.65	0.07	0.07
query5	0.51	0.49	0.51
query6	1.12	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.50	0.48
query10	0.55	0.56	0.54
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.59	0.60	0.60
query14	0.79	0.78	0.77
query15	0.83	0.81	0.81
query16	0.37	0.36	0.35
query17	1.03	1.01	0.93
query18	0.20	0.28	0.24
query19	1.77	1.80	1.75
query20	0.02	0.01	0.01
query21	15.67	0.68	0.67
query22	3.75	7.00	2.21
query23	18.31	1.36	1.25
query24	1.80	0.29	0.20
query25	0.13	0.09	0.08
query26	0.27	0.17	0.16
query27	0.08	0.08	0.08
query28	13.30	1.03	0.99
query29	12.76	3.33	3.31
query30	0.24	0.06	0.05
query31	2.85	0.39	0.39
query32	3.26	0.47	0.46
query33	2.80	2.84	2.85
query34	17.05	4.45	4.41
query35	4.49	4.52	4.62
query36	0.66	0.46	0.45
query37	0.17	0.15	0.16
query38	0.16	0.15	0.14
query39	0.04	0.04	0.03
query40	0.16	0.13	0.15
query41	0.09	0.06	0.06
query42	0.07	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 108.86 s
Total hot run time: 30.81 s

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41891 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ec028fbfacad377dd3581d3582dfdf47278c142e, data reload: false

------ Round 1 ----------------------------------
q1	17604	4339	4207	4207
q2	2015	192	192	192
q3	10438	1265	1280	1265
q4	10207	751	841	751
q5	7472	2836	2713	2713
q6	222	133	134	133
q7	1058	596	594	594
q8	9233	2150	2069	2069
q9	9323	6786	6746	6746
q10	9678	3945	3842	3842
q11	437	250	252	250
q12	484	223	226	223
q13	17935	3255	3271	3255
q14	249	218	220	218
q15	523	476	479	476
q16	528	417	395	395
q17	976	684	742	684
q18	8565	7724	7751	7724
q19	4962	1529	1541	1529
q20	621	319	312	312
q21	5401	4269	4019	4019
q22	347	310	294	294
Total cold run time: 118278 ms
Total hot run time: 41891 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4509	4364	4365	4364
q2	375	281	282	281
q3	3148	2938	2872	2872
q4	1894	1605	1651	1605
q5	5469	5478	5478	5478
q6	214	129	132	129
q7	2337	2005	2058	2005
q8	3222	3397	3364	3364
q9	8658	8747	8629	8629
q10	3933	3817	3889	3817
q11	586	486	484	484
q12	807	616	613	613
q13	15984	3146	3139	3139
q14	296	271	278	271
q15	515	477	485	477
q16	507	444	479	444
q17	1770	1491	1495	1491
q18	7686	8654	8018	8018
q19	1670	1515	1574	1515
q20	1992	1750	1752	1750
q21	8442	4991	4898	4898
q22	551	487	480	480
Total cold run time: 74565 ms
Total hot run time: 56124 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186346 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ec028fbfacad377dd3581d3582dfdf47278c142e, data reload: false

query1	915	376	367	367
query2	6433	2260	2265	2260
query3	6636	211	211	211
query4	22829	21246	21182	21182
query5	4176	414	418	414
query6	260	169	168	168
query7	4581	290	288	288
query8	234	182	183	182
query9	8463	2479	2451	2451
query10	441	245	261	245
query11	14770	14172	14185	14172
query12	143	89	92	89
query13	1651	388	384	384
query14	9689	7872	7722	7722
query15	212	168	180	168
query16	7728	257	262	257
query17	1509	557	554	554
query18	1936	277	261	261
query19	196	148	147	147
query20	91	86	82	82
query21	194	125	126	125
query22	5108	4856	4828	4828
query23	34528	33478	33360	33360
query24	6844	2908	2881	2881
query25	543	365	360	360
query26	700	152	160	152
query27	1939	326	328	326
query28	3817	2093	2068	2068
query29	845	610	609	609
query30	228	179	174	174
query31	958	768	755	755
query32	89	54	52	52
query33	473	248	238	238
query34	860	488	484	484
query35	759	664	699	664
query36	1030	910	924	910
query37	107	70	73	70
query38	2865	2770	2769	2769
query39	1590	1530	1576	1530
query40	196	123	125	123
query41	48	41	42	41
query42	101	91	97	91
query43	583	535	534	534
query44	1054	720	723	720
query45	265	259	258	258
query46	1077	714	699	699
query47	1935	1877	1874	1874
query48	379	303	293	293
query49	759	391	416	391
query50	763	390	386	386
query51	6629	6699	6600	6600
query52	102	90	95	90
query53	354	274	274	274
query54	521	430	450	430
query55	81	73	73	73
query56	245	219	223	219
query57	1216	1162	1143	1143
query58	229	196	199	196
query59	3448	3018	3003	3003
query60	256	226	232	226
query61	90	94	88	88
query62	576	472	451	451
query63	305	278	275	275
query64	8434	7391	7319	7319
query65	3121	3071	3096	3071
query66	772	340	341	340
query67	15263	14931	14923	14923
query68	4558	532	531	531
query69	488	297	305	297
query70	1192	1023	1097	1023
query71	397	267	270	267
query72	7920	2525	2390	2390
query73	701	325	328	325
query74	6485	6085	6000	6000
query75	3289	2646	2564	2564
query76	2266	1038	954	954
query77	372	259	256	256
query78	10564	10242	10008	10008
query79	2187	511	504	504
query80	1053	433	429	429
query81	528	241	244	241
query82	955	96	95	95
query83	243	162	163	162
query84	247	85	83	83
query85	1034	355	264	264
query86	454	320	287	287
query87	3313	3126	3101	3101
query88	3636	2450	2450	2450
query89	474	374	367	367
query90	2052	186	185	185
query91	124	98	99	98
query92	62	49	49	49
query93	1914	501	495	495
query94	1138	184	182	182
query95	391	298	300	298
query96	586	269	265	265
query97	3134	2983	3005	2983
query98	238	218	217	217
query99	1214	913	886	886
Total cold run time: 268381 ms
Total hot run time: 186346 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.15 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ec028fbfacad377dd3581d3582dfdf47278c142e, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.03
query3	0.23	0.06	0.06
query4	1.66	0.08	0.07
query5	0.50	0.46	0.51
query6	1.14	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.48
query10	0.53	0.54	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.13
query13	0.59	0.59	0.60
query14	0.77	0.81	0.76
query15	0.82	0.81	0.80
query16	0.35	0.37	0.36
query17	1.01	0.94	0.97
query18	0.22	0.22	0.25
query19	1.75	1.74	1.67
query20	0.02	0.01	0.01
query21	15.62	0.67	0.64
query22	4.29	7.62	1.72
query23	18.27	1.36	1.38
query24	1.97	0.23	0.22
query25	0.14	0.08	0.09
query26	0.26	0.15	0.16
query27	0.08	0.06	0.08
query28	13.27	1.02	0.99
query29	13.70	3.30	3.28
query30	0.24	0.06	0.06
query31	2.86	0.36	0.37
query32	3.30	0.47	0.46
query33	2.83	2.84	2.82
query34	17.21	4.44	4.41
query35	4.57	4.48	4.62
query36	0.65	0.45	0.46
query37	0.17	0.15	0.15
query38	0.16	0.14	0.14
query39	0.05	0.03	0.03
query40	0.16	0.15	0.14
query41	0.10	0.05	0.05
query42	0.05	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.61 s
Total hot run time: 30.15 s

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 8af8910 into apache:master May 15, 2024
@zclllyybb zclllyybb deleted the forbid_st branch May 15, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants