[Fix](temporary) temporarily forbid fold constant by BE for GeoFunctions#34857
Merged
HappenLee merged 1 commit intoapache:masterfrom May 15, 2024
Merged
[Fix](temporary) temporarily forbid fold constant by BE for GeoFunctions#34857HappenLee merged 1 commit intoapache:masterfrom
HappenLee merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
...core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnBE.java
Outdated
Show resolved
Hide resolved
TPC-H: Total hot run time: 41613 ms |
TPC-DS: Total hot run time: 187284 ms |
zhangstar333
approved these changes
May 14, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
ClickBench: Total hot run time: 30.81 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41891 ms |
TPC-DS: Total hot run time: 186346 ms |
ClickBench: Total hot run time: 30.15 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
now fold constant on BE may get wrong result for geofunctions. so we temporarily forbid it. Will release after we support real Geo types.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...