Skip to content

[enhance](Hdfs) Add bvar for currently inflight hdfs file writer's num #34863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 4 commits into from
May 16, 2024
Merged

[enhance](Hdfs) Add bvar for currently inflight hdfs file writer's num #34863

dataroaring merged 4 commits into from
May 16, 2024

Conversation

@ByteYue
Copy link
Contributor

@ByteYue ByteYue commented May 14, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented May 14, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@ByteYue
Copy link
Contributor Author

ByteYue commented May 14, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented May 14, 2024

TeamCity be ut coverage result:
Function Coverage: 35.66% (8984/25190)
Line Coverage: 27.33% (74280/271787)
Region Coverage: 26.56% (38379/144490)
Branch Coverage: 23.39% (19578/83718)
Coverage Report: http://coverage.selectdb-in.cc/coverage/80e02f657787feee02d4d6fee65abf26bda6508e_80e02f657787feee02d4d6fee65abf26bda6508e/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 14, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2024

PR approved by at least one committer and no changes requested.

platoneko
platoneko requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@platoneko platoneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between hdfs_file_being_written and inflight_hdfs_file_writer?

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 14, 2024
dataroaring pushed a commit that referenced this pull request May 15, 2024
@ByteYue
Pick "[enhance](Hdfs) Add bvar for currently inflight hdfs file write…
bd870a2 
…r's num #34863" #34865 (#34865)
@ByteYue
Copy link
Contributor Author

ByteYue commented May 15, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented May 15, 2024

TeamCity be ut coverage result:
Function Coverage: 35.65% (8983/25195)
Line Coverage: 27.32% (74268/271862)
Region Coverage: 26.56% (38384/144543)
Branch Coverage: 23.37% (19575/83754)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f71f8370b8bc347085f96a21e1b8ce84db16a60d_f71f8370b8bc347085f96a21e1b8ce84db16a60d/report/index.html

platoneko
platoneko reviewed May 15, 2024
View reviewed changes
@ByteYue
Copy link
Contributor Author

ByteYue commented May 16, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented May 16, 2024

TeamCity be ut coverage result:
Function Coverage: 35.70% (9004/25219)
Line Coverage: 27.37% (74480/272155)
Region Coverage: 26.61% (38504/144710)
Branch Coverage: 23.43% (19643/83838)
Coverage Report: http://coverage.selectdb-in.cc/coverage/98a3cee38c714ac65855d015d868e8d25dfa3c95_98a3cee38c714ac65855d015d868e8d25dfa3c95/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 16, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2024

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit fc64c65 into apache:master May 16, 2024
dataroaring pushed a commit that referenced this pull request May 16, 2024
@ByteYue @dataroaring
[enhance](Hdfs) Add bvar for currently inflight hdfs file writer's num (
95d7028 
#34863)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@platoneko platoneko platoneko approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ByteYue @doris-robot @gavinchou @platoneko @dataroaring