Skip to content

[fix](nereids) slot mapping bug when pushing rf into cte#34877

Merged
englefly merged 3 commits intoapache:masterfrom
englefly:rf-cte-slotmapping
May 16, 2024
Merged

[fix](nereids) slot mapping bug when pushing rf into cte#34877
englefly merged 3 commits intoapache:masterfrom
englefly:rf-cte-slotmapping

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented May 15, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented May 15, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@englefly
Copy link
Contributor Author

englefly commented May 15, 2024

run buildall

@englefly englefly force-pushed the rf-cte-slotmapping branch from 05df46a to a0dd0d0 Compare May 15, 2024 08:39
@englefly englefly force-pushed the rf-cte-slotmapping branch from a0dd0d0 to 701feb6 Compare May 15, 2024 08:41
@englefly
Copy link
Contributor Author

englefly commented May 15, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented May 15, 2024

run buildall

@doris-robot
Copy link

doris-robot commented May 15, 2024

TPC-H: Total hot run time: 41950 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f1052adc8bf11eeceb3a64aed6384f4fd1aa2ed6, data reload: false

------ Round 1 ----------------------------------
q1	17609	4342	4262	4262
q2	2011	181	189	181
q3	10490	1193	1178	1178
q4	10195	845	824	824
q5	7448	2735	2764	2735
q6	217	131	146	131
q7	1028	612	587	587
q8	9217	2155	2119	2119
q9	9691	6698	6696	6696
q10	9166	3874	3904	3874
q11	459	250	256	250
q12	461	231	237	231
q13	17341	3233	3172	3172
q14	278	219	224	219
q15	524	479	472	472
q16	511	420	394	394
q17	1006	767	691	691
q18	8321	7833	7769	7769
q19	5471	1547	1493	1493
q20	662	350	319	319
q21	5169	4072	4211	4072
q22	354	281	288	281
Total cold run time: 117629 ms
Total hot run time: 41950 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4571	4426	4385	4385
q2	375	284	273	273
q3	3177	2931	2943	2931
q4	1981	1711	1677	1677
q5	5342	5466	5482	5466
q6	215	128	125	125
q7	2301	1989	1960	1960
q8	3357	3420	3418	3418
q9	8590	8684	8656	8656
q10	4047	3816	3730	3730
q11	597	491	510	491
q12	785	623	620	620
q13	16226	3088	3180	3088
q14	284	276	272	272
q15	517	487	498	487
q16	497	444	439	439
q17	1826	1512	1516	1512
q18	7706	7641	7273	7273
q19	1649	1559	1538	1538
q20	1983	1807	1767	1767
q21	8956	4895	4723	4723
q22	599	496	499	496
Total cold run time: 75581 ms
Total hot run time: 55327 ms

@doris-robot
Copy link

doris-robot commented May 15, 2024

TPC-DS: Total hot run time: 187969 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f1052adc8bf11eeceb3a64aed6384f4fd1aa2ed6, data reload: false

query1	918	414	400	400
query2	6439	2383	2361	2361
query3	6639	213	214	213
query4	23335	21417	21281	21281
query5	4120	425	418	418
query6	259	189	180	180
query7	4581	308	290	290
query8	244	199	195	195
query9	8420	2397	2396	2396
query10	447	258	256	256
query11	15161	14675	14224	14224
query12	135	93	88	88
query13	1668	383	375	375
query14	11330	8705	7945	7945
query15	273	171	177	171
query16	8147	265	267	265
query17	1768	556	544	544
query18	2092	284	274	274
query19	330	154	150	150
query20	94	86	84	84
query21	196	140	132	132
query22	4996	4865	4893	4865
query23	34218	33509	33518	33509
query24	10581	2932	2920	2920
query25	576	363	358	358
query26	1099	170	165	165
query27	2299	328	331	328
query28	6869	2037	2052	2037
query29	862	613	616	613
query30	278	185	187	185
query31	975	745	734	734
query32	92	51	56	51
query33	724	243	249	243
query34	1029	503	488	488
query35	812	680	704	680
query36	1073	883	928	883
query37	135	71	70	70
query38	2888	2789	2761	2761
query39	1608	1576	1550	1550
query40	201	124	124	124
query41	46	43	43	43
query42	105	96	98	96
query43	583	531	561	531
query44	1165	774	749	749
query45	271	251	266	251
query46	1098	726	749	726
query47	1948	1924	1873	1873
query48	374	314	292	292
query49	849	409	395	395
query50	760	382	397	382
query51	7001	6924	6846	6846
query52	107	88	94	88
query53	352	282	292	282
query54	850	419	432	419
query55	76	82	78	78
query56	248	219	220	219
query57	1244	1170	1176	1170
query58	214	194	198	194
query59	3386	3050	3324	3050
query60	266	237	237	237
query61	90	89	91	89
query62	653	506	457	457
query63	319	282	280	280
query64	8832	7471	7453	7453
query65	3199	3136	3134	3134
query66	780	355	336	336
query67	15282	15058	14849	14849
query68	4482	535	523	523
query69	467	298	299	298
query70	1189	1084	1088	1084
query71	412	270	267	267
query72	7106	2606	2392	2392
query73	719	329	331	329
query74	6479	6115	6214	6115
query75	3394	2612	2637	2612
query76	2804	1025	1001	1001
query77	383	281	269	269
query78	10756	10293	10135	10135
query79	2524	529	530	529
query80	1169	454	447	447
query81	542	251	256	251
query82	944	105	99	99
query83	301	168	167	167
query84	246	87	84	84
query85	1235	267	259	259
query86	475	323	296	296
query87	3303	3089	3116	3089
query88	4349	2378	2358	2358
query89	464	379	373	373
query90	2030	190	193	190
query91	122	98	97	97
query92	57	49	49	49
query93	1810	514	495	495
query94	1231	176	180	176
query95	385	291	297	291
query96	595	265	271	265
query97	3187	2997	2999	2997
query98	242	221	215	215
query99	1187	896	892	892
Total cold run time: 282598 ms
Total hot run time: 187969 ms

@doris-robot
Copy link

doris-robot commented May 15, 2024

ClickBench: Total hot run time: 30.61 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f1052adc8bf11eeceb3a64aed6384f4fd1aa2ed6, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.04	0.05
query4	1.68	0.07	0.07
query5	0.51	0.48	0.52
query6	1.11	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.54	0.48	0.48
query10	0.52	0.55	0.54
query11	0.15	0.11	0.12
query12	0.14	0.11	0.12
query13	0.58	0.59	0.61
query14	0.80	0.76	0.78
query15	0.83	0.82	0.80
query16	0.38	0.37	0.37
query17	0.96	0.98	0.99
query18	0.22	0.24	0.27
query19	1.77	1.67	1.69
query20	0.01	0.02	0.01
query21	15.74	0.67	0.65
query22	4.07	7.32	2.19
query23	18.31	1.44	1.23
query24	1.66	0.31	0.20
query25	0.14	0.08	0.09
query26	0.26	0.17	0.17
query27	0.07	0.08	0.07
query28	13.32	1.02	1.00
query29	13.21	3.32	3.26
query30	0.24	0.06	0.05
query31	2.88	0.42	0.38
query32	3.26	0.47	0.47
query33	2.82	2.79	2.83
query34	17.12	4.44	4.51
query35	4.52	4.49	4.46
query36	0.69	0.48	0.48
query37	0.17	0.16	0.16
query38	0.15	0.15	0.15
query39	0.04	0.03	0.03
query40	0.15	0.13	0.14
query41	0.09	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.03	0.04
Total cold run time: 109.62 s
Total hot run time: 30.61 s

@englefly
Copy link
Contributor Author

englefly commented May 16, 2024

run performance

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 16, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2024

PR approved by anyone and no changes requested.

@englefly englefly merged commit 87a7ab9 into apache:master May 16, 2024
@englefly englefly deleted the rf-cte-slotmapping branch May 16, 2024 02:38
dataroaring pushed a commit that referenced this pull request May 16, 2024
@englefly @dataroaring
[fix](nereids) slot mapping bug when pushing rf into cte (#34877)
d60aeaa 
* fix bug: slot mapping bug when pushing rf into cte
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

+1 more reviewer

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.3-merged dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@englefly @doris-robot @starocean999 @LiBinfeng-01 @dataroaring @morrySnow