[fix](jdbc_catalog) fix error datetime literal caused be core #34977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
github-actions
bot
added
the
area/planner
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
|
this PR introduce a behavior change, below case will failed after this PR CREATE TABLE `roles` (
role_id INT,
occupation VARCHAR(32),
camp VARCHAR(32),
register_time DATE
)
UNIQUE KEY(role_id)
PARTITION BY RANGE (role_id)
(
PARTITION p1 VALUES LESS THAN ("10")
)
DISTRIBUTED BY HASH(role_id) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"binlog.enable" = "true"
);
INSERT INTO `roles` VALUES
(0, 'who am I', NULL, NULL),
(1, 'mage', 'alliance', '2018-12-03 16:11:28'),
(2, 'paladin', 'alliance', '2018-11-30 16:11:28'),
(3, 'rogue', 'horde', '2018-12-01 16:11:28'),
(4, 'priest', 'alliance', '2018-12-02 16:11:28'),
(5, 'shaman', 'horde', NULL),
(6, 'warrior', 'alliance', NULL),
(7, 'warlock', 'horde', '2018-12-04 16:11:28'),
(8, 'hunter', 'horde', NULL); the original plan is right. the bug should be fixed on BE |
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
May 24, 2024
…apache#34977)" This reverts commit cddf62b. It introduce a behavior change, below case will failed after this PR CREATE TABLE `roles` ( role_id INT, occupation VARCHAR(32), camp VARCHAR(32), register_time DATE ) UNIQUE KEY(role_id) PARTITION BY RANGE (role_id) ( PARTITION p1 VALUES LESS THAN ("10") ) DISTRIBUTED BY HASH(role_id) BUCKETS 1 PROPERTIES ( "replication_allocation" = "tag.location.default: 1", "binlog.enable" = "true" ); INSERT INTO `roles` VALUES (0, 'who am I', NULL, NULL), (1, 'mage', 'alliance', '2018-12-03 16:11:28'), (2, 'paladin', 'alliance', '2018-11-30 16:11:28'), (3, 'rogue', 'horde', '2018-12-01 16:11:28'), (4, 'priest', 'alliance', '2018-12-02 16:11:28'), (5, 'shaman', 'horde', NULL), (6, 'warrior', 'alliance', NULL), (7, 'warlock', 'horde', '2018-12-04 16:11:28'), (8, 'hunter', 'horde', NULL); the original plan is right. the bug should be fixed on BE
morrySnow
added a commit
that referenced
this pull request
May 24, 2024
…#34977)" (#35341) This reverts commit cddf62b. This reverts PR #34977. It introduce a behavior change, below case will failed after this PR CREATE TABLE `roles` ( role_id INT, occupation VARCHAR(32), camp VARCHAR(32), register_time DATE ) UNIQUE KEY(role_id) PARTITION BY RANGE (role_id) ( PARTITION p1 VALUES LESS THAN ("10") ) DISTRIBUTED BY HASH(role_id) BUCKETS 1 PROPERTIES ( "replication_allocation" = "tag.location.default: 1", "binlog.enable" = "true" ); INSERT INTO `roles` VALUES (0, 'who am I', NULL, NULL), (1, 'mage', 'alliance', '2018-12-03 16:11:28'), (2, 'paladin', 'alliance', '2018-11-30 16:11:28'), (3, 'rogue', 'horde', '2018-12-01 16:11:28'), (4, 'priest', 'alliance', '2018-12-02 16:11:28'), (5, 'shaman', 'horde', NULL), (6, 'warrior', 'alliance', NULL), (7, 'warlock', 'horde', '2018-12-04 16:11:28'), (8, 'hunter', 'horde', NULL); the original plan is right. the bug should be fixed on BE
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…#34977) * [fix](jdbc_catalog) fix error datetime literal caused be core * fix error regression test * fix regression test
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…apache#34977)" (apache#35341) This reverts commit cddf62b. This reverts PR apache#34977. It introduce a behavior change, below case will failed after this PR CREATE TABLE `roles` ( role_id INT, occupation VARCHAR(32), camp VARCHAR(32), register_time DATE ) UNIQUE KEY(role_id) PARTITION BY RANGE (role_id) ( PARTITION p1 VALUES LESS THAN ("10") ) DISTRIBUTED BY HASH(role_id) BUCKETS 1 PROPERTIES ( "replication_allocation" = "tag.location.default: 1", "binlog.enable" = "true" ); INSERT INTO `roles` VALUES (0, 'who am I', NULL, NULL), (1, 'mage', 'alliance', '2018-12-03 16:11:28'), (2, 'paladin', 'alliance', '2018-11-30 16:11:28'), (3, 'rogue', 'horde', '2018-12-01 16:11:28'), (4, 'priest', 'alliance', '2018-12-02 16:11:28'), (5, 'shaman', 'horde', NULL), (6, 'warrior', 'alliance', NULL), (7, 'warlock', 'horde', '2018-12-04 16:11:28'), (8, 'hunter', 'horde', NULL); the original plan is right. the bug should be fixed on BE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #34975
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...